Review main Merged

73932[BUGFIX] Make file paths absolute in GIFBUILDER

Simon Schaufelberger CR +2 V +2 Hard +221 −42 updated 06/06/22, 18:02

Commit message

In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inconsistency, absolute
file paths are used from now on.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 5077

Show 3052 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 03/14/22, 23:41

  2. Simon Schaufelberger commented on patch set 1 03/14/22, 23:44

    This is a different solution for the same problem like https://review.typo3.org/c/Packages/TYPO3.CMS/+/73862. Here I work with absolute path from the dimension cache while the other solution works with relative paths
  3. core-ci voted on patch set 1 V -1 03/14/22, 23:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24896

  4. Simon Schaufelberger uploaded patch set 2 03/15/22, 00:21

  5. core-ci voted on patch set 2 V -1 03/15/22, 00:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24898

  6. Simon Schaufelberger uploaded patch set 3 03/15/22, 13:56

  7. core-ci voted on patch set 3 V -1 03/15/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24906

  8. Simon Schaufelberger uploaded patch set 4 03/15/22, 14:30

  9. core-ci voted on patch set 4 V +1 03/15/22, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24907

  10. Simon Schaufelberger rebased onto patch set 5 03/21/22, 16:08

  11. core-ci voted on patch set 5 V +1 03/21/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25034

  12. Simon Schaufelberger uploaded patch set 6 03/22/22, 16:27

  13. Simon Schaufelberger uploaded patch set 7 03/22/22, 16:32

  14. core-ci voted on patch set 6 V -1 03/22/22, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25053

  15. core-ci voted on patch set 7 V +1 03/22/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25054

  16. Simon Schaufelberger rebased onto patch set 8 03/28/22, 19:18

  17. Simon Schaufelberger commented on patch set 8 03/28/22, 19:19

  18. core-ci voted on patch set 8 V +1 03/28/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25228

  19. Simon Schaufelberger rebased onto patch set 9 04/19/22, 12:18

  20. core-ci voted on patch set 9 V -1 04/19/22, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26184

  21. Nikita Hovratov commented on patch set 9 04/19/22, 13:31

    Added a fix for your failing tests here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74356
  22. Simon Schaufelberger rebased onto patch set 10 04/20/22, 14:37

  23. core-ci voted on patch set 10 V +1 04/20/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26238

  24. Simon Schaufelberger rebased onto patch set 11 04/22/22, 23:05

  25. core-ci voted on patch set 11 V +1 04/22/22, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26331

  26. Stefan Bürk commented on patch set 11 V -1 CR -1 04/24/22, 12:08

    Thanks for the patch, and also for the second try after the last regression. Basically it seems that the composer / one level public folder seems to work. However, there is now something odd with the output folder at all. Generally spoken, the generated image is expected to be in: ``` /(|public/)/typo3temp/assets/_processed_/xxxx ``` but is instead writte to ``` /(|public/)/fileadmin/typo3temp/assets/_processed_/xxxx ``` This is wrong. Not checked where the error lies. I think you have to work on this again. Commented exact filename/paths for each test. Taking this as an essential error, thus -1.
    No candidate for 10.4 backport from core point of view.

    GifBuilderTest.php:57

    wrong output path: ``` > expected: typo3temp/var/tests/functional-d8db697/public/typo3temp/assets/_processed_/9/3/csm_kasper-skarhoj-gifbuilder_b63b8ab897.gif > actual..: typo3temp/var/tests/functional-d8db697/public/fileadmin/typo3temp/assets/_processed_/9/3/csm_kasper-skarhoj-gifbuilder_b63b8ab897.gif ```

    GifBuilderTest.php:112

    wrong output path: ``` > expected: typo3temp/var/tests/functional-d8db697/public/typo3temp/assets/_processed_/9/3/csm_kasper-skarhoj-gifbuilder_b63b8ab897.gif > actual..: typo3temp/var/tests/functional-d8db697/public/fileadmin/typo3temp/assets/_processed_/9/3/csm_kasper-skarhoj-gifbuilder_b63b8ab897.gif ```

    GifBuilderTest.php:194

    wrong output path: ``` > expected: /var/www/work/t3c/core-main/core-main/typo3temp/var/tests/functional-d8db697/typo3temp/assets/_processed_/d/5/csm_kasper-skarhoj1_6199155dc1.gif > actual..: /var/www/work/t3c/core-main/core-main/typo3temp/var/tests/functional-d8db697/fileadmin/typo3temp/assets/_processed_/d/5/csm_kasper-skarhoj1_6199155dc1.gif > expected: /var/www/work/t3c/core-main/core-main/typo3temp/var/tests/functional-d8db697/typo3temp/assets/_processed_/d/5/csm_kasper-skarhoj1_d151fe2f28.gif > actual..: /var/www/work/t3c/core-main/core-main/typo3temp/var/tests/functional-d8db697/fileadmin/typo3temp/assets/_processed_/d/5/csm_kasper-skarhoj1_d151fe2f28.gif ```
  27. Simon Schaufelberger commented on patch set 11 04/26/22, 10:43

    GifBuilderTest.php:57 Reply

    This has to do with line 73 where the sys_file_storage of the testing framework is imported which sets a "processingfolder" (which is not set in a default installation). If I unset the processingfolder in the xml and run the tests again, everything works as expected, so this is purely a testing-framework issue.

    GifBuilderTest.php:112 Reply

    Done

    GifBuilderTest.php:194 Reply

    Done
  28. Simon Schaufelberger commented on patch set 11 04/26/22, 10:44

    Reply

    This has to do with line 73 where the sys_file_storage of the testing framework is imported which sets a "processingfolder" (which is not set in a default installation). If I unset the processingfolder in the xml and run the tests again, everything works as expected, so this is purely a testing-framework issue.
  29. Simon Schaufelberger commented on patch set 11 04/26/22, 10:47

    Reply

    Done
  30. Simon Schaufelberger uploaded patch set 12 04/26/22, 10:47

  31. core-ci voted on patch set 12 V -1 04/26/22, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26449

  32. core-ci voted on patch set 12 V +1 04/26/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26449

  33. Simon Schaufelberger commented on patch set 12 04/26/22, 13:13

  34. Simon Schaufelberger commented on patch set 12 04/26/22, 13:24

    GifBuilder.php:189

  35. Simon Schaufelberger commented on patch set 12 05/18/22, 11:03

    GifBuilder.php:189 Reply

    Done
  36. Stefan Bürk rebased onto patch set 13 05/18/22, 11:29

  37. core-ci voted on patch set 13 V -1 05/18/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27297

  38. core-ci voted on patch set 13 V +1 05/18/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27297

  39. Simon Schaufelberger updated the commit message in patch set 14 05/18/22, 12:46

  40. core-ci voted on patch set 14 V +1 05/18/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27298

  41. Stefan Bürk rebased onto patch set 15 05/23/22, 20:46

  42. core-ci voted on patch set 15 V +1 05/23/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27415

  43. Stefan Bürk voted on patch set 15 CR +1 05/24/22, 10:38

  44. Simon Schaufelberger uploaded patch set 16 05/24/22, 13:37

  45. core-ci voted on patch set 16 V +1 05/24/22, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27432

  46. Simon Schaufelberger rebased onto patch set 17 05/25/22, 11:38

  47. core-ci voted on patch set 17 V +1 05/25/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27449

  48. Simon Schaufelberger uploaded patch set 18 05/25/22, 12:33

  49. Simon Schaufelberger uploaded patch set 19 05/25/22, 12:35

  50. core-ci voted on patch set 18 V -1 05/25/22, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27453

  51. core-ci voted on patch set 19 V -1 05/25/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27454

  52. core-ci voted on patch set 19 V +1 05/25/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27454

  1. Stefan Bürk rebased onto patch set 20 05/28/22, 21:34

  2. Simon Schaufelberger commented on patch set 20 05/28/22, 21:41

    why another rebase?
  3. core-ci voted on patch set 20 V +1 05/28/22, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27532

  4. Stefan Bürk commented on patch set 20 05/28/22, 21:46

    Reply

    Simply timing - let ci re-run tests while doing other things/reviews beforepicking this patch now up re-reviewing/verification.
  5. Stefan Bürk commented on patch set 20 CR -1 05/28/22, 21:49

    on it ...
  6. Stefan Bürk voted on patch set 20 V +1 CR +1 05/28/22, 22:08

  7. Nikita Hovratov commented on patch set 20 05/30/22, 10:28

    ContentObjectRenderer.php:3825

    Let's use !== '' as we are expecting a string value.

    GifBuilderTest.php:73

    Can we move everything beneath this line into a seperate test method, as we are testing different things?

    GifBuilderTest.php:86

    This can be directly inlined into $GLOBALS['TSFE']

    GifBuilderTest.php:168

    The exact same thing is already tested in buildImageInCommandLineInterfaceAndComposerContext. Do we need it twice?

    GifBuilderTest.php:171

    (Same as above) Can we move everything beneath this line into a seperate test method, as we are testing different things?

    GifBuilderTest.php:184

    This can be directly inlined into $GLOBALS['TSFE']
  8. Simon Schaufelberger commented on patch set 20 05/30/22, 11:57

    GifBuilderTest.php:73 Reply

    Done

    GifBuilderTest.php:86 Reply

    Done

    GifBuilderTest.php:168 Reply

    No. This is copy paste code :D

    GifBuilderTest.php:171 Reply

    This is the main test case, actually.

    GifBuilderTest.php:184 Reply

    Done
  9. Simon Schaufelberger commented on patch set 20 05/30/22, 12:00

    ContentObjectRenderer.php:3825 Reply

    Done
  10. Simon Schaufelberger uploaded patch set 21 05/30/22, 12:05

  11. core-ci voted on patch set 21 V +1 05/30/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27583

  12. Nikita Hovratov voted on patch set 21 V +1 CR +1 05/30/22, 16:44

  13. Nikita Hovratov commented on patch set 21 V 0 CR 0 05/30/22, 16:54

    GifBuilderTest.php:226

    It seems more like the getFile method of StorageRepository is not correctly typehinted. It should actually have the same as getFileByIdentifier. I would say we can fix this in another patch. Here it is unrelated and just a workaround.
  14. Simon Schaufelberger commented on patch set 21 05/30/22, 18:24

    GifBuilderTest.php:226 Reply

    should I revert that?
  15. Nikita Hovratov commented on patch set 21 05/31/22, 07:11

    GifBuilderTest.php:226 Reply

    I would suggest so. Or else there will be a followup patch "remove unneeded docblock annotations" at some point.
  16. Simon Schaufelberger commented on patch set 21 05/31/22, 10:51

    GifBuilderTest.php:226 Reply

    Done
  17. Simon Schaufelberger uploaded patch set 22 05/31/22, 10:52

  18. Simon Schaufelberger uploaded patch set 23 05/31/22, 10:53

  19. core-ci voted on patch set 22 V -1 05/31/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27596

  20. core-ci voted on patch set 23 V -1 05/31/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27597

  21. core-ci voted on patch set 23 V +1 06/01/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27597

  22. Stefan Bürk voted on patch set 23 V +1 CR +1 06/04/22, 04:32

  23. Nikita Hovratov voted on patch set 23 V +1 CR +1 06/04/22, 20:50

  24. Stefan Bürk voted on patch set 23 V +2 CR +2 06/06/22, 18:02

  25. Stefan Bürk merged patch set 24 06/06/22, 18:02