Review main Abandoned

7394[FEATURE] File references direct edit link

Andrea Schmuttermair CR 0 V 0 Easy +17 −4 updated 12/08/14, 19:09

Commit message

In filelist column "Ref" shows number of file references.
On click an info-popup shows the tt_content uid of all references.
This feature adds an direct edit link to the filelist table.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 15

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Wow, amazing! You "rejected" this rather small patch and missed to add FAL as well for 4.7. So it turns out we won't have it at all. And since with 4.8 it won't go in then we won't even have it in any of the possible backport-releases. It's not about this feature in particular but how all the handling was done. So if I summarized the situation above, is this a candidate to abandon and mark as "won't have, never"? :-(
    would be 6.0 meanwhile
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Needs some small CGL-cleanups (whitespace) and testing. But despite that it looks okay imho. About "enough votes": The history looks like there are/were no votes at all yet - but at least no -1 :-)
  3. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve CGL-cleanup, raised Releases-line to 4.8 since feature-freeze of 4.7
  4. Stefan Neufeind uploaded patch set 2 05/27/13, 17:19

  5. Stefan Neufeind commented on patch set 3 V 0 05/27/13, 17:19

    See screenshot in forge. verified it works as advertised. But I'm unsure whether we'd maybe better have the edit-link inside the infopopup. If you have a long list of files and multiple references each I think this here would clutter the filelist quite much.
  6. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  7. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    (1 inline comment) Somebody please have a look at this and make a UX-decision.
  8. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    No score Does this still apply for 6.0+? Or is it maybe obsolete since the arrival of FAL?
  9. Steffen Ritter commented on patch set 1 05/27/13, 17:19

    there is no -1 isnt it? therefore can be merged with enough votes... right?
  10. Steffen Ritter commented on patch set 1 05/27/13, 17:19

    Hello Andreas, the current file-list will be replaced as we are integrating FAL. So this won't be needed there.
  11. Andrea Schmuttermair commented on patch set 3 05/27/13, 17:19

    @Stephan: But I'm unsure whether we'd maybe better have the edit-link inside the infopopup. Please not in the info popup - that was the main reason for that patch. My customer had lots of references, so it was very annoying always loading the info popup to change all referenced content.
  12. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3515/ : FAILURE
  14. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  15. Georg Ringer abandoned the change 12/08/14, 19:09

    because of FAL, not needed anymore