73974[BUGFIX] Remove usage of undefined variable
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1316
-
Georg Ringer uploaded patch set 1 03/16/22, 08:43
-
Georg Ringer commented on patch set 1 03/16/22, 08:43
This change is ready for review. -
Georg Ringer commented on patch set 1 03/16/22, 08:44
FYI: I don't know if this the correct solution! -
core-ci voted on patch set 1 V -1 03/16/22, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24935
-
Georg Ringer uploaded patch set 2 03/16/22, 11:22
-
core-ci voted on patch set 2 V +1 03/16/22, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24943
-
Stefan Bürk commented on patch set 2 03/16/22, 14:22
FinisherOptionsFlexFormOverridesConverter.php:84I would add a ` && !empty($value)` to the if conditions in L75. Thus making the check here superflous and we can simply assign it ``` $value = $processedOptionValue; ``` -
Oliver Klee voted on patch set 2 CR +1 03/16/22, 14:34
-
Christian Kuhn commented on patch set 2 03/29/22, 08:13
FinisherOptionsFlexFormOverridesConverter.php:84Replyi'd actually keep it as proposed - there is quite some fiddling with $value already that is hard to follow, so i'd rather not add it to the if() above again. -
Christian Kuhn rebased onto patch set 3 03/29/22, 08:14
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/29/22, 08:15
-
core-ci voted on patch set 3 V +1 03/29/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25246
-
Stefan Bürk commented on patch set 3 V +1 CR +1 03/29/22, 09:36
FinisherOptionsFlexFormOverridesConverter.php:84ReplyFine with that. -
Oliver Klee voted on patch set 3 CR +1 03/29/22, 10:01
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/29/22, 10:14
-
Christian Kuhn merged patch set 4 03/29/22, 10:14