Review main Merged

73977[BUGFIX] Filter eval list in link and email element

Oli Bartsch CR +2 V +2 Easy +13 −6 updated 03/21/22, 15:11

Commit message

With #97013 and #97159, two dedicated TCA
types were added, which both only allow a few
eval options. To prevent invalid options being
passed as attributes to the HTML element, the
list is now filtered for the allowed options.

Additionally, the "trim" option is always added.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 913

  1. Oli Bartsch uploaded patch set 1 03/16/22, 13:32

  2. Oli Bartsch uploaded patch set 2 03/16/22, 13:37

  3. core-ci voted on patch set 1 V +1 03/16/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24944

  4. core-ci voted on patch set 2 V -1 03/16/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24945

  5. core-ci voted on patch set 2 V +1 03/16/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24945

  6. Markus Klein updated the commit message in patch set 3 03/16/22, 14:20

  7. core-ci voted on patch set 3 V +1 03/16/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24946

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 03/16/22, 17:30

  9. Nikita Hovratov commented on patch set 3 V +1 CR +1 03/17/22, 19:16

    Interestingly the value is automatically trimmed for (html) type="email" fields, even without this patch. But I couldn't figure out why.
  10. Markus Klein commented on patch set 3 03/18/22, 18:48

    Reply

    I guess the browser does this.
  11. Benni Mack voted on patch set 3 V +1 CR +1 03/21/22, 11:36

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 03/21/22, 15:11

  13. Oli Bartsch merged patch set 4 03/21/22, 15:11