Review main Merged Breaking

73982[!!!][FEATURE] Add PSR-14 ModifyNewContentElementWizardItemsEvent

Oli Bartsch CR +2 V +2 Hard +698 −207 updated 03/21/22, 12:29

Commit message

This introduces a new PSR-14 event, enabling extension
authors to modify the items of the new content element
wizard component.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms']['db_new_content_el']['wizardItemsHook']
which is therefore now removed.

Additionally, the NewContentElementController receives
some code cleanup, e.g. removing the "params" parameter
from the wizard items' configuration, which previously
just duplicated the "tt_content_defValues" property.

Also, four public methods have been removed from
the class as they were only used for the now
removed hook and are now available in the
PSR-14 Event directly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 710

  1. Oli Bartsch uploaded patch set 1 03/17/22, 00:46

  2. core-ci voted on patch set 1 V +1 03/17/22, 01:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24959

  3. Oli Bartsch uploaded patch set 2 03/17/22, 21:30

  4. core-ci voted on patch set 2 V +1 03/17/22, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24975

  5. Oli Bartsch uploaded patch set 3 03/17/22, 22:14

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 03/17/22, 22:23

  7. core-ci voted on patch set 3 V +1 03/17/22, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24978

  8. Benni Mack voted on patch set 3 V +1 CR +1 03/21/22, 11:46

  9. Georg Ringer voted on patch set 3 V +2 CR +2 03/21/22, 12:29

  10. Georg Ringer merged patch set 4 03/21/22, 12:29