Review main Merged

73983[BUGFIX] Ensure imageLinkWrap works with UTF-8 filenames

Xavier Perseguers CR +2 V +2 Easy +2 −1 updated 03/29/22, 11:28

Commit message

The unset($info['originalFile']) introduced in #90565
broke an access to that array key below in the method.
This leads to the situation that files with UTF-8
characters are not found anymore since the imageLinkWrap()
method is fed with an encoded version of the filename
and not the original file object anymore.
The patch parks $info['originalFile'] in a variable
to access it for imageLinkWrap() again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1114

  1. Xavier Perseguers uploaded patch set 1 03/17/22, 08:09

  2. Xavier Perseguers voted on patch set 1 V +1 CR +1 03/17/22, 08:10

  3. core-ci voted on patch set 1 V +1 03/17/22, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24963

  4. Christian Kuhn updated the commit message in patch set 2 03/29/22, 07:39

  5. core-ci voted on patch set 2 V +1 03/29/22, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25244

  6. Christian Kuhn uploaded patch set 3 03/29/22, 07:58

  7. Christian Kuhn commented on patch set 3 V +1 CR +1 03/29/22, 07:59

  8. core-ci voted on patch set 3 V +1 03/29/22, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25245

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 03/29/22, 08:28

  10. Oli Bartsch commented on patch set 3 03/29/22, 08:42

    Should we add a test for this?
  11. Christian Kuhn commented on patch set 3 03/29/22, 10:15

    Reply

    unsure how exactly - as unit test, it would need to mock quite something, as functional test, we'd need a full TS setup plus a file ... imho fine to go as is for now?
  12. Christian Kuhn voted on patch set 3 V +2 CR +2 03/29/22, 10:43

  13. Christian Kuhn merged patch set 4 03/29/22, 10:43

  14. Xavier Perseguers commented on patch set 4 03/29/22, 11:28

    Unresolved

    unfortunate that this bug fix reported for v10 already isn't backported there