73986[TASK] Add modern typing to MathUtility
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1622
-
crell uploaded patch set 1 03/17/22, 19:56
-
core-ci voted on patch set 1 V -1 03/17/22, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24969
-
Oli Bartsch commented on patch set 1 V -1 03/17/22, 21:45
Adding type hints to parameters of API methods is a breaking change which has to be documented as such. -
crell uploaded patch set 2 03/28/22, 17:01
-
Oliver Klee voted on patch set 2 CR +1 03/28/22, 17:06
-
core-ci voted on patch set 2 V +1 03/28/22, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25225
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 03/28/22, 19:35
-
Stefan Bürk updated the commit message in patch set 3 03/28/22, 20:44
-
core-ci voted on patch set 3 V +1 03/28/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25232
-
Stefan Bürk uploaded patch set 4 03/28/22, 21:26
-
Stefan Bürk uploaded patch set 5 03/28/22, 21:28
-
core-ci voted on patch set 4 V +1 03/28/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25234
-
core-ci voted on patch set 5 V +1 03/28/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25235
-
Oliver Klee voted on patch set 5 CR +1 03/28/22, 21:47
-
Stefan Bürk commented on patch set 5 CR -1 03/29/22, 10:15
It may be similar, but the used replacement does not. Used replacement changes the range and thus the behaviour. See comments for method.MathUtility.php:55docblock type <=> argument type missmatch. Should be changed to 'mixed'.MathUtility.php:60Do not get why you replaced that here. 1. the adding a call which using a condition more 2. limit the "max" to lower. Original "max" was automaticlly PHP_INT_MAX, default 'max' for called method is lower than that '2000000000' At least, third argument with PHP_INT_MAX must be given to keep the same behaviour and range as before. But would keep the original prior to calling the forceInterInRange() method. -
crell commented on patch set 5 03/29/22, 14:45
Reply
DoneMathUtility.php:55ReplyDoneMathUtility.php:60ReplyAdded the PHP_MAX_INT argument. I think it's better to still fold the methods together, though, as their logic is the same. This isn't along a critical path so any performance impact either way is likely to be undetectable. -
crell uploaded patch set 6 03/29/22, 14:46
-
core-ci voted on patch set 6 V +1 03/29/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25263
-
Oliver Klee voted on patch set 6 CR +1 03/29/22, 15:09
-
Stefan Bürk voted on patch set 6 V +1 CR +1 03/29/22, 18:05
-
Christian Kuhn voted on patch set 6 V +2 CR +2 03/29/22, 18:07
-
Christian Kuhn merged patch set 7 03/29/22, 18:07