73988[!!!][TASK] Add native typing to CommandUtility
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 6
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+2 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php10+45 −60
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignatures.rst+1 −0
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+1 −1
Review log 2736
Show 711 earlier messages
-
crell uploaded patch set 1 03/17/22, 20:34
-
core-ci voted on patch set 1 V -1 03/17/22, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24971
-
Oli Bartsch commented on patch set 1 V -1 03/17/22, 21:43
Adding type hints parameters of API methods is a breaking change which has to be documented as such.CommandUtility.php:53Adding typed properties, the annotations can be removed. -
crell uploaded patch set 2 04/04/22, 16:16
-
crell commented on patch set 2 04/04/22, 16:26
CommandUtility.php:53ReplyDone -
core-ci voted on patch set 2 V -1 04/04/22, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25441
-
crell uploaded patch set 3 04/04/22, 17:44
-
core-ci voted on patch set 3 V +1 04/04/22, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25453
-
Nikita Hovratov uploaded patch set 4 04/04/22, 18:32
-
Simon Schaufelberger commented on patch set 4 04/04/22, 18:45
CommandUtility.php:251I wonder why there is a whitespace at the end which will be trimmed anyway in the next line. -
core-ci voted on patch set 4 V +1 04/04/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25455
-
crell commented on patch set 4 04/04/22, 18:50
CommandUtility.php:251ReplyNo idea. I wasn't looking at that kind of logic issue. Could be left-over from some older version of the code. Shall I remove it as long as we're here? -
Oliver Klee commented on patch set 4 04/04/22, 18:57
CommandUtility.php:270We can provide even more specific typing here: array<string, string> -
Stefan Bürk commented on patch set 4 04/04/22, 19:06
what aboutCommandUtility.php:2Should we not add ``` declare(strict_types=1); ``` now ? -
Stefan Bürk commented on patch set 4 04/04/22, 19:07
Reply
ignore that .. ;) -
Nikita Hovratov uploaded patch set 5 04/05/22, 06:43
-
Nikita Hovratov commented on patch set 4 04/05/22, 06:44
CommandUtility.php:2ReplyDoneCommandUtility.php:270ReplyDone -
core-ci voted on patch set 5 V -1 04/05/22, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25467
-
core-ci voted on patch set 5 V +1 04/05/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25467
-
Nikita Hovratov commented on patch set 5 04/05/22, 07:14
CommandUtility.php:251ReplyLet's focus on strict types here, to not have too much refactoring, which makes it harder to review. This can be fixed another time, with added tests maybe. -
Oliver Klee voted on patch set 5 CR +1 04/05/22, 08:40
-
crell commented on patch set 5 CR +1 04/05/22, 13:16
CommandUtility.php:251ReplyAck -
Simon Schaufelberger wrote 04/05/22, 23:18
Removed cc Simon Schaufelberger. -
Nikita Hovratov uploaded patch set 6 04/08/22, 17:47
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 04/08/22, 17:50
-
core-ci voted on patch set 6 V +1 04/08/22, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25850
-
Stefan Bürk commented on patch set 6 CR -1 04/08/22, 17:56
on it -
Stefan Bürk updated the commit message in patch set 7 04/08/22, 18:18
-
Stefan Bürk updated the commit message in patch set 8 04/08/22, 18:19
-
Stefan Bürk voted on patch set 8 V +1 CR +1 04/08/22, 18:19
-
Oliver Klee voted on patch set 8 CR +1 04/08/22, 18:24
-
core-ci voted on patch set 7 V +1 04/08/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25852
-
core-ci voted on patch set 8 V +1 04/08/22, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25853
-
Nikita Hovratov voted on patch set 8 V +1 CR +1 04/08/22, 18:35
-
Georg Ringer voted on patch set 8 V +2 CR +2 04/08/22, 18:59
-
Georg Ringer merged patch set 9 04/08/22, 18:59