Review main Merged Breaking

73988[!!!][TASK] Add native typing to CommandUtility

crell CR +2 V +2 Normal +50 −68 updated 04/08/22, 18:59

Commit message

Nothing particularly exciting, but does remove another
PHPStan baseline message.

A few bits of unnecessary code have been removed or
cleaned up.

Additionally, a few locations in code were calling
CommandUtility::exec() incorrectly in a way that
has always been incorrect. These are fixed now.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2736

Show 711 earlier messages
  1. crell uploaded patch set 1 03/17/22, 20:34

  2. core-ci voted on patch set 1 V -1 03/17/22, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24971

  3. Oli Bartsch commented on patch set 1 V -1 03/17/22, 21:43

    Adding type hints parameters of API methods is a breaking change which has to be documented as such.

    CommandUtility.php:53

    Adding typed properties, the annotations can be removed.
  4. crell uploaded patch set 2 04/04/22, 16:16

  5. crell commented on patch set 2 04/04/22, 16:26

    CommandUtility.php:53 Reply

    Done
  6. core-ci voted on patch set 2 V -1 04/04/22, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25441

  7. crell uploaded patch set 3 04/04/22, 17:44

  8. core-ci voted on patch set 3 V +1 04/04/22, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25453

  9. Nikita Hovratov uploaded patch set 4 04/04/22, 18:32

  10. Simon Schaufelberger commented on patch set 4 04/04/22, 18:45

    CommandUtility.php:251

    I wonder why there is a whitespace at the end which will be trimmed anyway in the next line.
  11. core-ci voted on patch set 4 V +1 04/04/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25455

  1. crell commented on patch set 4 04/04/22, 18:50

    CommandUtility.php:251 Reply

    No idea. I wasn't looking at that kind of logic issue. Could be left-over from some older version of the code. Shall I remove it as long as we're here?
  2. Oliver Klee commented on patch set 4 04/04/22, 18:57

    CommandUtility.php:270

    We can provide even more specific typing here: array<string, string>
  3. Stefan Bürk commented on patch set 4 04/04/22, 19:06

    what about

    CommandUtility.php:2

    Should we not add ``` declare(strict_types=1); ``` now ?
  4. Stefan Bürk commented on patch set 4 04/04/22, 19:07

    Reply

    ignore that .. ;)
  5. Nikita Hovratov uploaded patch set 5 04/05/22, 06:43

  6. Nikita Hovratov commented on patch set 4 04/05/22, 06:44

    CommandUtility.php:2 Reply

    Done

    CommandUtility.php:270 Reply

    Done
  7. core-ci voted on patch set 5 V -1 04/05/22, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25467

  8. core-ci voted on patch set 5 V +1 04/05/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25467

  9. Nikita Hovratov commented on patch set 5 04/05/22, 07:14

    CommandUtility.php:251 Reply

    Let's focus on strict types here, to not have too much refactoring, which makes it harder to review. This can be fixed another time, with added tests maybe.
  10. Oliver Klee voted on patch set 5 CR +1 04/05/22, 08:40

  11. crell commented on patch set 5 CR +1 04/05/22, 13:16

    CommandUtility.php:251 Reply

    Ack
  12. Simon Schaufelberger wrote 04/05/22, 23:18

    Removed cc Simon Schaufelberger.
  13. Nikita Hovratov uploaded patch set 6 04/08/22, 17:47

  14. Nikita Hovratov voted on patch set 6 V +1 CR +1 04/08/22, 17:50

  15. core-ci voted on patch set 6 V +1 04/08/22, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25850

  16. Stefan Bürk commented on patch set 6 CR -1 04/08/22, 17:56

    on it
  17. Stefan Bürk updated the commit message in patch set 7 04/08/22, 18:18

  18. Stefan Bürk updated the commit message in patch set 8 04/08/22, 18:19

  19. Stefan Bürk voted on patch set 8 V +1 CR +1 04/08/22, 18:19

  20. Oliver Klee voted on patch set 8 CR +1 04/08/22, 18:24

  21. core-ci voted on patch set 7 V +1 04/08/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25852

  22. core-ci voted on patch set 8 V +1 04/08/22, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25853

  23. Nikita Hovratov voted on patch set 8 V +1 CR +1 04/08/22, 18:35

  24. Georg Ringer voted on patch set 8 V +2 CR +2 04/08/22, 18:59

  25. Georg Ringer merged patch set 9 04/08/22, 18:59