Review main Merged

73990[TASK] Raise typo3/testing-framework

Stefan Bürk CR +2 V +2 Normal +98 −20 updated 05/09/22, 23:46

Commit message

Along some minor changes, TF frontend requests now directly
submit the InternalRequest to the core's application chain
without explicitly transitioning them to a ServerRequestInterface
since TF InternalRequest now directly extends core's ServerRequest.

This simplifies the class chain and is the general way to go.

* tests are adjusted to test against adjusted sync between
  'body' and 'parsedBody'
* tests added for request uri query arguments and request
  queryParams syncronization in different constellations

See: https://github.com/TYPO3/testing-framework/pull/355

Used commands:

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1937

Show 612 earlier messages
  1. Stefan Bürk uploaded patch set 1 03/17/22, 21:30

  2. core-ci voted on patch set 1 V +1 03/17/22, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24976

  3. Stefan Bürk uploaded patch set 2 03/27/22, 12:10

  4. core-ci voted on patch set 2 V +1 03/27/22, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25185

  5. Stefan Bürk uploaded patch set 3 03/27/22, 20:55

  6. core-ci voted on patch set 3 V +1 03/27/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25190

  7. Stefan Bürk uploaded patch set 4 03/29/22, 22:03

  8. core-ci voted on patch set 4 V -1 03/29/22, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25271

  9. Stefan Bürk uploaded patch set 5 03/29/22, 22:53

  10. core-ci voted on patch set 5 V +1 03/29/22, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25274

  11. Stefan Bürk rebased onto patch set 6 04/11/22, 15:14

  12. core-ci voted on patch set 6 V -1 04/11/22, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25926

  1. core-ci voted on patch set 6 V +1 04/11/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25926

  2. Stefan Bürk uploaded patch set 7 04/17/22, 21:09

  3. core-ci voted on patch set 7 V +1 04/17/22, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26125

  4. Stefan Bürk uploaded patch set 8 04/24/22, 18:31

  5. Stefan Bürk updated the commit message in patch set 9 04/24/22, 18:32

  6. core-ci voted on patch set 8 V +1 04/24/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26376

  7. core-ci voted on patch set 9 V +1 04/24/22, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26377

  8. Stefan Bürk uploaded patch set 10 04/30/22, 16:08

  9. core-ci voted on patch set 10 V -1 04/30/22, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26696

  10. core-ci commented on patch set 10 04/30/22, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26696

  11. core-ci voted on patch set 10 V +1 04/30/22, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26696

  12. Stefan Bürk uploaded patch set 11 05/09/22, 22:24

  13. core-ci voted on patch set 11 V +1 05/09/22, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27058

  14. Stefan Bürk uploaded patch set 12 05/09/22, 22:38

  15. core-ci voted on patch set 12 V +1 05/09/22, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27059

  16. Stefan Bürk updated the commit message in patch set 13 05/09/22, 22:55

  17. core-ci voted on patch set 13 V +1 05/09/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27061

  18. Christian Kuhn updated the commit message in patch set 14 05/09/22, 23:15

  19. Christian Kuhn updated the commit message in patch set 15 05/09/22, 23:16

  20. core-ci voted on patch set 15 V +1 05/09/22, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27066

  21. core-ci voted on patch set 13 V +1 05/09/22, 23:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27062

  22. Christian Kuhn voted on patch set 15 V +1 CR +1 05/09/22, 23:46

  23. Christian Kuhn commented on patch set 15 05/09/22, 23:46

    needs to be merged now to prevent red nightlies.
  24. Stefan Bürk voted on patch set 15 V +2 CR +2 05/09/22, 23:46

  25. Stefan Bürk merged patch set 16 05/09/22, 23:46