73991[!!!][TASK] Add native typing for DebugUtility
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 3
Review log 2534
Show 79 earlier messages
-
crell uploaded patch set 1 03/17/22, 22:10
-
core-ci voted on patch set 1 V +1 03/17/22, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24977
-
Oli Bartsch commented on patch set 1 V -1 03/17/22, 22:23
As for the other patches, adding type hints to parameters of API methods is a breaking change which has to be documented as such. -
crell uploaded patch set 2 04/13/22, 15:52
-
core-ci voted on patch set 2 V +1 04/13/22, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25989
-
Oliver Klee voted on patch set 2 CR +1 04/13/22, 16:18
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 04/14/22, 18:14
-
Jörg Bösche voted on patch set 2 CR +1 04/27/22, 11:16
-
Stefan Bürk commented on patch set 2 CR -1 04/27/22, 13:53
Breaking ReSt missing. (Either dedicated one or amending to a collection Breaking ReST file).GlobalDebugFunctions.php:2What's the reason I missed for not declaring this declare strict ?
-
crell commented on patch set 2 04/27/22, 15:15
Reply
The corresponding Forge ticket is linked to this one: https://forge.typo3.org/issues/97372 Once all of the *Utility updates are done, I will update the existing RST file in one batch. It's done this way to keep these patches from all conflicting with each other on a trivial update to that file, but they're all tracked so they don't get lost.GlobalDebugFunctions.php:2ReplyNone, I missed it. Will add. -
Stefan Bürk commented on patch set 2 04/27/22, 15:20
Reply
Your decision. Than no vote/merge from me. Cannot take respsonsible of the already not correct linked list in that issue for a later making of that file. As already mentioned: We have done this with a lot of deprecation removal patches without hazzle. And no need to avoid anything. -
crell uploaded patch set 3 04/27/22, 15:21
-
Oliver Klee voted on patch set 3 CR +1 04/27/22, 15:25
-
core-ci voted on patch set 3 V -1 04/27/22, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26520
-
core-ci voted on patch set 3 V +1 04/27/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26520
-
Josef Glatz updated the commit message in patch set 4 04/29/22, 08:59
-
core-ci voted on patch set 4 V +1 04/29/22, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26645
-
Oliver Klee voted on patch set 4 CR +1 04/29/22, 09:23
-
Simon Schaufelberger voted on patch set 4 V +1 CR +1 04/30/22, 09:38
-
Oliver Hader commented on patch set 4 05/02/22, 09:30
Nitpick... please reduce the commit message to the necessary and relevant information. Currently it reads like a diary entry ;-) -
crell uploaded patch set 5 05/02/22, 16:06
-
crell commented on patch set 4 05/02/22, 16:08
Reply
Done -
Oliver Klee voted on patch set 5 CR +1 05/02/22, 16:16
-
Oliver Hader voted on patch set 5 CR +1 05/02/22, 16:17
-
core-ci voted on patch set 5 V +1 05/02/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26738
-
Georg Ringer voted on patch set 5 V +1 CR +1 05/03/22, 21:36
-
Nikita Hovratov uploaded patch set 6 05/06/22, 10:32
-
Oliver Klee voted on patch set 6 CR +1 05/06/22, 10:45
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 05/06/22, 10:57
-
core-ci voted on patch set 6 V -1 05/06/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26901
-
core-ci commented on patch set 6 05/06/22, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26901
-
core-ci voted on patch set 6 V +1 05/06/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26901
-
Stefan Bürk voted on patch set 6 V +2 CR +2 05/06/22, 11:36
-
Stefan Bürk merged patch set 7 05/06/22, 11:36