Review main Merged

73993[TASK] Move TypoLinkCodecService to EXT:core

Oli Bartsch CR +2 V +2 Normal +114 −16 updated 03/22/22, 06:47

Commit message

EXT:core unfortunately has a couple of dependencies
to EXT:frontend. One of them are TypoLinkCodecService.

Since this service does not have any context, only related
to EXT:frontend, it is now moved to EXT:core, resolving this
cross dependency.

This also allows to use the service in the DataHandler
instead of duplicating parts of the code, which was
previously done to prevent any EXT:frontend dependency
in the DataHandler.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1319

  1. Oli Bartsch uploaded patch set 1 03/18/22, 01:13

  2. Oli Bartsch updated the commit message in patch set 2 03/18/22, 01:15

  3. core-ci voted on patch set 1 V -1 03/18/22, 02:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24981

  4. core-ci voted on patch set 2 V -1 03/18/22, 02:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24982

  5. Mathias Brodala commented on patch set 2 03/18/22, 07:46

    TypoLinkCodecService.php:28

    This should be done with a separate change IMO for the usual reasons: 1. We stick to a single topic with an atomic change 2. We reduce the risk of introducing regressions 3. We avoid having to revert the whole change in case of issues
  6. Oli Bartsch uploaded patch set 3 03/21/22, 13:21

  7. Oli Bartsch uploaded patch set 4 03/21/22, 13:23

  8. Oli Bartsch commented on patch set 4 03/21/22, 13:25

    TypoLinkCodecService.php:28 Reply

    Done
  9. Oliver Hader voted on patch set 4 CR +1 03/21/22, 13:47

  10. Oliver Hader voted on patch set 4 V +1 03/21/22, 13:52

  11. core-ci voted on patch set 3 V -1 03/21/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25023

  12. core-ci voted on patch set 4 V -1 03/21/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25024

  13. Oli Bartsch uploaded patch set 5 03/21/22, 14:35

  14. core-ci voted on patch set 5 V +1 03/21/22, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25026

  15. Oli Bartsch uploaded patch set 6 03/21/22, 15:11

  16. core-ci voted on patch set 6 V +1 03/21/22, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25030

  17. Benni Mack voted on patch set 6 V +1 CR +1 03/21/22, 20:47

  18. Georg Ringer voted on patch set 6 V +2 CR +2 03/22/22, 06:47

  19. Georg Ringer merged patch set 7 03/22/22, 06:47