Review main Merged

73995[BUGFIX] Fix undefined array key warning in GifBuilder

Simon Schaufelberger CR +2 V +2 Easy +3 −3 updated 03/24/22, 13:43

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Simon Schaufelberger uploaded patch set 1 03/18/22, 23:08

  2. core-ci voted on patch set 1 V +1 03/18/22, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24993

  3. Oliver Klee voted on patch set 1 CR +1 03/19/22, 10:13

  4. Oliver Hader voted on patch set 1 CR +1 03/21/22, 10:40

  5. Oli Bartsch commented on patch set 1 03/21/22, 15:02

    How can this be reproduced?
  6. Simon Schaufelberger commented on patch set 1 03/22/22, 16:09

    Reply

    I had this case once but I guess the Typoscript was broken in that case. Anyway, this is how you can reproduce it: lib.test = IMAGE lib.test { file = GIFBUILDER file { XY = 640,480 format = png 10 = IMAGE } } page > page = PAGE page.1 < lib.test so the typoscript settings of the image is incomplete. There is another error afterwards but that is a different story.
  7. Oli Bartsch commented on patch set 1 03/22/22, 16:18

    Reply

    Oke I was able to reproduce the warning. Should we fix the same error in L:167, too?
  8. Simon Schaufelberger uploaded patch set 2 03/23/22, 22:26

  9. Simon Schaufelberger commented on patch set 2 03/23/22, 22:27

    good catch!
  10. core-ci voted on patch set 2 V +1 03/23/22, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25087

  11. Oliver Klee voted on patch set 2 CR +1 03/24/22, 11:17

  12. Markus Klein voted on patch set 2 V +1 CR +1 03/24/22, 13:38

  13. Oli Bartsch commented on patch set 2 V +2 CR +2 03/24/22, 13:43

    Reply

    Done
  14. Oli Bartsch merged patch set 3 03/24/22, 13:43