73995[BUGFIX] Fix undefined array key warning in GifBuilder
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Oli Bartsch +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Simon Schaufelberger uploaded patch set 1 03/18/22, 23:08
-
core-ci voted on patch set 1 V +1 03/18/22, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24993
-
Oliver Klee voted on patch set 1 CR +1 03/19/22, 10:13
-
Oliver Hader voted on patch set 1 CR +1 03/21/22, 10:40
-
Oli Bartsch commented on patch set 1 03/21/22, 15:02
How can this be reproduced? -
Simon Schaufelberger commented on patch set 1 03/22/22, 16:09
Reply
I had this case once but I guess the Typoscript was broken in that case. Anyway, this is how you can reproduce it: lib.test = IMAGE lib.test { file = GIFBUILDER file { XY = 640,480 format = png 10 = IMAGE } } page > page = PAGE page.1 < lib.test so the typoscript settings of the image is incomplete. There is another error afterwards but that is a different story. -
Oli Bartsch commented on patch set 1 03/22/22, 16:18
Reply
Oke I was able to reproduce the warning. Should we fix the same error in L:167, too? -
Simon Schaufelberger uploaded patch set 2 03/23/22, 22:26
-
Simon Schaufelberger commented on patch set 2 03/23/22, 22:27
good catch! -
core-ci voted on patch set 2 V +1 03/23/22, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25087
-
Oliver Klee voted on patch set 2 CR +1 03/24/22, 11:17
-
Markus Klein voted on patch set 2 V +1 CR +1 03/24/22, 13:38
-
Oli Bartsch commented on patch set 2 V +2 CR +2 03/24/22, 13:43
Reply
Done -
Oli Bartsch merged patch set 3 03/24/22, 13:43