73999[BUGFIX] Accept native TIME value '00:00:00' in backend forms
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Oliver Hader uploaded patch set 1 03/21/22, 12:31
-
core-ci voted on patch set 1 V -1 03/21/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25018
-
core-ci voted on patch set 1 V +1 03/21/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25018
-
Benni Mack voted on patch set 1 CR +1 03/21/22, 15:46
-
Simon Schaufelberger commented on patch set 1 03/26/22, 10:34
is it possible to write a test for that as well? -
Oliver Klee commented on patch set 1 03/26/22, 17:10
I think this change would very much benefit from covering the new behavior with tests. -
Benni Mack commented on patch set 1 03/29/22, 20:27
DatabaseRowDateTimeFields.php:50what does "reset" do? Can't find it here https://docs.typo3.org/m/typo3/reference-tca/main/en-us/ColumnsConfig/Type/Input/DateTime/Properties/Index.html -
Oliver Hader commented on patch set 1 03/30/22, 20:23
DatabaseRowDateTimeFields.php:50ReplyReset is from https://review.typo3.org/c/Packages/TYPO3.CMS/+/73999/1/typo3/sysext/core/Classes/Database/Query/QueryHelper.php - it "resets to an empty-like value". Not sure whether these props need to be documented at the resource you mentioned. -
Oli Bartsch uploaded patch set 2 04/01/22, 09:40
-
core-ci voted on patch set 2 V +1 04/01/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25334
-
Oli Bartsch voted on patch set 2 V +1 CR +1 04/01/22, 09:58
-
Benni Mack commented on patch set 2 V +1 CR +1 04/01/22, 10:00
DatabaseRowDateTimeFields.php:50ReplyDone -
Oli Bartsch voted on patch set 2 V +2 CR +2 04/01/22, 10:02
-
Oli Bartsch merged patch set 3 04/01/22, 10:02