Review main Merged

73999[BUGFIX] Accept native TIME value '00:00:00' in backend forms

Oliver Hader CR +2 V +2 Easy +35 −2 updated 04/01/22, 10:02

Commit message

Native date/time types have a zero-value, which is '0000-00-00 00:00:00'
for DATETIME and '00:00:00' for TIME. For DATETIME values this position
in time is really special - however, for TIME values '00:00:00' it would
refer to midnight, which actually is common use case (and currently not
possible in backend forms).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Oliver Hader uploaded patch set 1 03/21/22, 12:31

  2. core-ci voted on patch set 1 V -1 03/21/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25018

  3. core-ci voted on patch set 1 V +1 03/21/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25018

  4. Benni Mack voted on patch set 1 CR +1 03/21/22, 15:46

  5. Simon Schaufelberger commented on patch set 1 03/26/22, 10:34

    is it possible to write a test for that as well?
  6. Oliver Klee commented on patch set 1 03/26/22, 17:10

    I think this change would very much benefit from covering the new behavior with tests.
  7. Benni Mack commented on patch set 1 03/29/22, 20:27

    DatabaseRowDateTimeFields.php:50

  8. Oliver Hader commented on patch set 1 03/30/22, 20:23

    DatabaseRowDateTimeFields.php:50 Reply

    Reset is from https://review.typo3.org/c/Packages/TYPO3.CMS/+/73999/1/typo3/sysext/core/Classes/Database/Query/QueryHelper.php - it "resets to an empty-like value". Not sure whether these props need to be documented at the resource you mentioned.
  9. Oli Bartsch uploaded patch set 2 04/01/22, 09:40

  10. core-ci voted on patch set 2 V +1 04/01/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25334

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 04/01/22, 09:58

  12. Benni Mack commented on patch set 2 V +1 CR +1 04/01/22, 10:00

    DatabaseRowDateTimeFields.php:50 Reply

    Done
  13. Oli Bartsch voted on patch set 2 V +2 CR +2 04/01/22, 10:02

  14. Oli Bartsch merged patch set 3 04/01/22, 10:02