Review main Merged

74003[TASK] Remove superfluous trait from FormEngine elements

Oli Bartsch CR +2 V +2 Easy +0 −39 updated 03/22/22, 09:13

Commit message

This removes the import of OnFieldChangeTrait from
all FormEngine elements, extending AbstractFormElement,
since the abstract class already imports the trait.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 67

  1. Oli Bartsch uploaded patch set 1 03/21/22, 16:56

  2. core-ci voted on patch set 1 V +1 03/21/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25036

  3. Oliver Hader voted on patch set 1 CR +1 03/21/22, 17:27

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/21/22, 20:29

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 03/22/22, 07:18

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 03/22/22, 09:13

  7. Oli Bartsch merged patch set 2 03/22/22, 09:13