Review main Merged

74014[TASK] Increase DB size of password fields to 255

Torben Hansen CR +2 V +2 Easy +2 −2 updated 03/22/22, 09:22

Commit message

To support future password hashing algorithms, it is
recommended by PHP to use a DB size of 255 chars for
fields storing password hashes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Torben Hansen uploaded patch set 1 03/22/22, 07:19

  2. core-ci voted on patch set 1 V +1 03/22/22, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25044

  3. Stefan Bürk commented on patch set 1 03/22/22, 07:48

  4. Stefan Bürk commented on patch set 1 03/22/22, 07:48

    Reply

    Or do I miss something ?
  5. Torben Hansen commented on patch set 1 03/22/22, 08:15

    Reply

    Yes, theoretically this could be adapted, but for fe_users and be_users there is currently no real dependency between the TCA field max length and the DB field size. Passwords are stored as hashes in the DB and the result of the hashed field value will currently always be < 100 chars. So actually we currently limit the password to be max. 100 chars, but for no real reason. We will therefore also remove the TCA max. setting for the upcoming TCA type=password (#97104 - max. setting still present, but I will remove this later). It this change should be included in #97104, I'm also fine with that.
  6. Oli Bartsch voted on patch set 1 V +1 CR +1 03/22/22, 09:17

  7. Benni Mack voted on patch set 1 V +1 CR +1 03/22/22, 09:19

  8. Oli Bartsch commented on patch set 1 V +2 CR +2 03/22/22, 09:22

    Reply

    Done
  9. Oli Bartsch merged patch set 2 03/22/22, 09:22