74014[TASK] Increase DB size of password fields to 255
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Torben Hansen uploaded patch set 1 03/22/22, 07:19
-
core-ci voted on patch set 1 V +1 03/22/22, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25044
-
Stefan Bürk commented on patch set 1 03/22/22, 07:48
Not checkout and tested, but should the TCA field definition not be updated/increased too ? (Just asking, never looked how these fields works yet) https://github.com/TYPO3/typo3/blob/a04b5771ea1ba86b25330fc8d9c82cb30b9ac633/typo3/sysext/core/Configuration/TCA/be_users.php#L58 https://github.com/TYPO3/typo3/blob/a04b5771ea1ba86b25330fc8d9c82cb30b9ac633/typo3/sysext/frontend/Configuration/TCA/fe_users.php#L42 -
Stefan Bürk commented on patch set 1 03/22/22, 07:48
Reply
Or do I miss something ? -
Torben Hansen commented on patch set 1 03/22/22, 08:15
Reply
Yes, theoretically this could be adapted, but for fe_users and be_users there is currently no real dependency between the TCA field max length and the DB field size. Passwords are stored as hashes in the DB and the result of the hashed field value will currently always be < 100 chars. So actually we currently limit the password to be max. 100 chars, but for no real reason. We will therefore also remove the TCA max. setting for the upcoming TCA type=password (#97104 - max. setting still present, but I will remove this later). It this change should be included in #97104, I'm also fine with that. -
Oli Bartsch voted on patch set 1 V +1 CR +1 03/22/22, 09:17
-
Benni Mack voted on patch set 1 V +1 CR +1 03/22/22, 09:19
-
Oli Bartsch commented on patch set 1 V +2 CR +2 03/22/22, 09:22
Reply
Done -
Oli Bartsch merged patch set 2 03/22/22, 09:22