Review main Merged

74016[FEATURE] Allow to directly declare static route variables

Oliver Hader CR +2 V +2 Hard +347 −9 updated 08/06/24, 20:17

Commit message

Instead of having to use custom route aspect mappers, implementing
`StaticMappableAspectInterface`, to avoid having `&cHash=` signatures
being applied to the generated URL, variables now can be simply
declared `static` in the corresponding route enhancer configuration.

By using the new `static` route configuration directive, custom aspect
mapper implementations can be avoided. However, static route variables
are only applied for a particular variable name if no other aspect
mapper is defined (those would take precedence) and if a companion
`requirements` definition is given (should be restrictive, to reduce
possible cache flooding scenarios).

Example:

routeEnhancers:
  Verification:
    type: Simple
    routePath: '/verify/{code}'
    static:
      code: true
    requirements:
      code: '[a-f0-9]{40}'

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1221

  1. Oliver Hader uploaded patch set 1 03/22/22, 12:50

  2. core-ci voted on patch set 1 V +1 03/22/22, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25049

  3. Oliver Hader rebased onto patch set 2 11/10/22, 12:16

  4. core-ci voted on patch set 2 V +1 11/10/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33485

  5. Oliver Hader uploaded patch set 3 V +1 03/14/24, 20:40

  6. Oliver Hader uploaded patch set 4 03/14/24, 20:47

  7. core-ci voted on patch set 3 V -1 03/14/24, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54554

  8. Oliver Hader uploaded patch set 5 03/14/24, 20:52

  9. core-ci voted on patch set 4 V -1 03/14/24, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54555

  10. core-ci voted on patch set 5 V +1 03/14/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54556

  11. Oliver Hader uploaded patch set 6 V +1 03/15/24, 08:29

  12. core-ci voted on patch set 6 V +1 03/15/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54569

  13. Benni Mack commented on patch set 7 V +1 08/06/24, 12:37

    Published edit on patch set 6.
  14. core-ci voted on patch set 7 V -1 08/06/24, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62928

  15. Benni Mack rebased onto patch set 8 V -1 08/06/24, 15:43

  16. core-ci voted on patch set 8 V -1 08/06/24, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62955

  17. Oliver Hader uploaded patch set 9 V -1 08/06/24, 19:29

  18. core-ci voted on patch set 9 V +1 08/06/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62968

  19. Benni Mack voted on patch set 9 CR +1 V +1 08/06/24, 20:17

  20. Georg Ringer voted on patch set 9 CR +2 V +2 08/06/24, 20:17

  21. Georg Ringer merged patch set 10 08/06/24, 20:17