Review main Merged

74018[BUGFIX] Execute symfony commands in scheduler as non-interactive

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 03/23/22, 17:35

Commit message

The Scheduler module provides the option to
execute symfony commands. Since those
commands are usually built for CLI execution
they might also contain interactive components
like questions, which however can not be used
when execution is scheduled.

Therefore, the console input is now set to be
non-interactive in the ExecuteSchedulableCommandTask
"wrapper" class.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Oli Bartsch uploaded patch set 1 03/22/22, 15:48

  2. Oli Bartsch commented on patch set 1 03/22/22, 15:51

    The command "cleanup:lostfiles" from the issue does no longer exist in v12. The behaviour can however also be verified with "cleanup:missingrelations".
  3. Oliver Klee voted on patch set 1 CR +1 03/22/22, 15:51

  4. core-ci voted on patch set 1 V +1 03/22/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25051

  5. Mathias Brodala commented on patch set 1 03/22/22, 16:15

    ExecuteSchedulableCommandTask.php:105

    I'd suggest to move this directly after $input initalization. And drop the comment which does not add any value. ;-)
  6. Oli Bartsch uploaded patch set 2 03/22/22, 16:56

  7. Oli Bartsch commented on patch set 2 03/22/22, 16:57

    ExecuteSchedulableCommandTask.php:105 Reply

    Done
  8. core-ci voted on patch set 2 V +1 03/22/22, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25055

  9. Oliver Klee voted on patch set 2 CR +1 03/22/22, 17:10

  10. Mathias Brodala voted on patch set 2 CR +1 03/22/22, 17:18

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 03/23/22, 17:28

  12. Benni Mack voted on patch set 2 V +1 CR +1 03/23/22, 17:34

  13. Oli Bartsch voted on patch set 2 V +2 CR +2 03/23/22, 17:35

  14. Oli Bartsch merged patch set 3 03/23/22, 17:35