74018[BUGFIX] Execute symfony commands in scheduler as non-interactive
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Mathias Brodala +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Oli Bartsch uploaded patch set 1 03/22/22, 15:48
-
Oli Bartsch commented on patch set 1 03/22/22, 15:51
The command "cleanup:lostfiles" from the issue does no longer exist in v12. The behaviour can however also be verified with "cleanup:missingrelations". -
Oliver Klee voted on patch set 1 CR +1 03/22/22, 15:51
-
core-ci voted on patch set 1 V +1 03/22/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25051
-
Mathias Brodala commented on patch set 1 03/22/22, 16:15
ExecuteSchedulableCommandTask.php:105I'd suggest to move this directly after $input initalization. And drop the comment which does not add any value. ;-) -
Oli Bartsch uploaded patch set 2 03/22/22, 16:56
-
Oli Bartsch commented on patch set 2 03/22/22, 16:57
ExecuteSchedulableCommandTask.php:105ReplyDone -
core-ci voted on patch set 2 V +1 03/22/22, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25055
-
Oliver Klee voted on patch set 2 CR +1 03/22/22, 17:10
-
Mathias Brodala voted on patch set 2 CR +1 03/22/22, 17:18
-
Stefan Bürk voted on patch set 2 V +1 CR +1 03/23/22, 17:28
-
Benni Mack voted on patch set 2 V +1 CR +1 03/23/22, 17:34
-
Oli Bartsch voted on patch set 2 V +2 CR +2 03/23/22, 17:35
-
Oli Bartsch merged patch set 3 03/23/22, 17:35