Review main Merged

74024[BUGFIX] Allow installation of incompatible distributions

Andreas Kienast CR +2 V +2 Normal +34 −34 updated 03/25/22, 08:16

Commit message

TYPO3 allows to install incompatible extensions for a very long time,
but distributions were missed when this feature was introduced.
This patch now offers the same "Dependencies could not be resolved"
dialog for distributions that miss dependencies.

As this dialog is now used in different contexts, the "Go back" action
has been made configurable.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1012

  1. Andreas Kienast uploaded patch set 1 03/23/22, 12:23

  2. core-ci voted on patch set 1 V +1 03/23/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25077

  3. Oli Bartsch commented on patch set 1 03/23/22, 12:47

    DownloadController.php:161

    Since we type hinted this parameter, do we need a type cast here?

    DownloadController.php:197

    Are those error messages no longer relevant?

    UnresolvedDependencies.html:25

    While already on it, should we use a locallang key? E.g. "LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.goBack"
  4. Andreas Kienast commented on patch set 1 03/23/22, 12:52

    DownloadController.php:161 Reply

    Fair enough, I can also remove the type cast again, whatever you prefer.

    DownloadController.php:197 Reply

    Nope, those errors are handled again in unresolvedDependenciesAction and its rendered template

    UnresolvedDependencies.html:25 Reply

    Ack
  5. Andreas Kienast commented on patch set 1 03/23/22, 12:56

    DownloadController.php:161 Reply

    I'll add a string type declaration as well, the underlying code will fail anyway if a non-string value is passed.
  6. Andreas Kienast uploaded patch set 2 03/23/22, 12:57

  7. Oli Bartsch commented on patch set 1 03/23/22, 12:57

    DownloadController.php:161 Reply

    type hints on parameters is always a good improvement. I would therefore just add a (string) type cast here.

    DownloadController.php:197 Reply

    Ack
  8. core-ci voted on patch set 2 V +1 03/23/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25079

  9. Oli Bartsch commented on patch set 2 V +1 CR +1 03/24/22, 21:34

    DownloadController.php:161 Reply

    Even better with the typecast on the action parameter.
  10. Benni Mack voted on patch set 2 V +1 CR +1 03/24/22, 22:08

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 03/25/22, 08:16

  12. Andreas Kienast merged patch set 3 03/25/22, 08:16