74024[BUGFIX] Allow installation of incompatible distributions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+9 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php8+12 −24
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+2 −1
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+9 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/UnresolvedDependencies.html2+2 −2
Review log 1012
-
Andreas Kienast uploaded patch set 1 03/23/22, 12:23
-
core-ci voted on patch set 1 V +1 03/23/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25077
-
Oli Bartsch commented on patch set 1 03/23/22, 12:47
DownloadController.php:197Are those error messages no longer relevant?UnresolvedDependencies.html:25While already on it, should we use a locallang key? E.g. "LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.goBack" -
Andreas Kienast commented on patch set 1 03/23/22, 12:52
DownloadController.php:161ReplyFair enough, I can also remove the type cast again, whatever you prefer.DownloadController.php:197ReplyNope, those errors are handled again in unresolvedDependenciesAction and its rendered templateUnresolvedDependencies.html:25ReplyAck -
Andreas Kienast commented on patch set 1 03/23/22, 12:56
DownloadController.php:161ReplyI'll add a string type declaration as well, the underlying code will fail anyway if a non-string value is passed. -
Andreas Kienast uploaded patch set 2 03/23/22, 12:57
-
Oli Bartsch commented on patch set 1 03/23/22, 12:57
DownloadController.php:161Replytype hints on parameters is always a good improvement. I would therefore just add a (string) type cast here.DownloadController.php:197ReplyAck -
core-ci voted on patch set 2 V +1 03/23/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25079
-
Oli Bartsch commented on patch set 2 V +1 CR +1 03/24/22, 21:34
DownloadController.php:161ReplyEven better with the typecast on the action parameter. -
Benni Mack voted on patch set 2 V +1 CR +1 03/24/22, 22:08
-
Andreas Kienast voted on patch set 2 V +2 CR +2 03/25/22, 08:16
-
Andreas Kienast merged patch set 3 03/25/22, 08:16
DownloadController.php:161