Review main Merged Breaking

74025[!!!][FEATURE] Add PSR-14 ModifyImageManipulationPreviewUrlEvent

Oli Bartsch CR +2 V +2 Normal +175 −21 updated 03/25/22, 11:16

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the preview url within
the image manipulation element, used e.g. for the
`crop` field of `sys_file_reference`.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['Backend/Form/Element/ImageManipulationElement']['previewUrl']
which is therefore now removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1621

  1. Oli Bartsch uploaded patch set 1 03/23/22, 12:31

  2. core-ci voted on patch set 1 V +1 03/23/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25078

  3. Oli Bartsch uploaded patch set 2 03/23/22, 17:12

  4. core-ci voted on patch set 2 V +1 03/23/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25083

  5. Oli Bartsch uploaded patch set 3 03/23/22, 22:41

  6. core-ci voted on patch set 3 V +1 03/23/22, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25089

  7. Andreas Kienast commented on patch set 3 03/24/22, 07:48

    Does it make sense to backport this bugfix to v11 and maybe even v10? If so, I suggest extracting this change into a separate patch.
  8. Oli Bartsch uploaded patch set 4 03/24/22, 20:04

  9. Oli Bartsch commented on patch set 4 03/24/22, 20:11

  10. core-ci voted on patch set 4 V +1 03/24/22, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25114

  11. Benni Mack commented on patch set 4 03/24/22, 20:50

    ArrayDimensionMatcher.php:671

    didn't you want to add the FeatureRST as done like above?
  12. Oli Bartsch uploaded patch set 5 03/24/22, 22:09

  13. Oli Bartsch commented on patch set 5 03/24/22, 22:09

    ArrayDimensionMatcher.php:671 Reply

    Done
  14. Benni Mack voted on patch set 5 V +1 CR +1 03/24/22, 22:21

  15. core-ci voted on patch set 5 V +1 03/24/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25118

  16. Simon Schaufelberger commented on patch set 5 03/24/22, 23:25

    ImageManipulationElement.php:200

    what about moving the code above the arguments? that would make it a bit easier for debugging instead of calling several functions when creating the arguments array. I would have even liked it to keep the method as before and only adjust the body.
  17. Oli Bartsch commented on patch set 5 03/25/22, 09:34

    ImageManipulationElement.php:200 Reply

    How would debugging be easier then? It's still possible to set a breakpoint to this line. I actually did exactly this while creating the patch. I also don't see the need for an extra method which just returns this statement.
  18. Jochen Roth voted on patch set 5 V +1 CR +1 03/25/22, 10:51

  19. Stefan Bürk voted on patch set 5 V +1 CR +1 03/25/22, 11:09

  20. Oli Bartsch voted on patch set 5 V +2 CR +2 03/25/22, 11:16

  21. Oli Bartsch merged patch set 6 03/25/22, 11:16