74025[!!!][FEATURE] Add PSR-14 ModifyImageManipulationPreviewUrlEvent
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php2+5 −21
- typo3/sysext/backend/Classes/Form/Event/ModifyImageManipulationPreviewUrlEvent.phpnew+60 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97230-RemovedHookForModifyingImageManipulationPreviewUrl.rstnew+35 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97230-PSR-14EventForModifyingImageManipulationPreviewUrl.rstnew+69 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php2+6 −0
Review log 1621
-
Oli Bartsch uploaded patch set 1 03/23/22, 12:31
-
core-ci voted on patch set 1 V +1 03/23/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25078
-
Oli Bartsch uploaded patch set 2 03/23/22, 17:12
-
core-ci voted on patch set 2 V +1 03/23/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25083
-
Oli Bartsch uploaded patch set 3 03/23/22, 22:41
-
core-ci voted on patch set 3 V +1 03/23/22, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25089
-
Andreas Kienast commented on patch set 3 03/24/22, 07:48
Does it make sense to backport this bugfix to v11 and maybe even v10? If so, I suggest extracting this change into a separate patch. -
Oli Bartsch uploaded patch set 4 03/24/22, 20:04
-
Oli Bartsch commented on patch set 4 03/24/22, 20:11
-
core-ci voted on patch set 4 V +1 03/24/22, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25114
-
Benni Mack commented on patch set 4 03/24/22, 20:50
ArrayDimensionMatcher.php:671didn't you want to add the FeatureRST as done like above? -
Oli Bartsch uploaded patch set 5 03/24/22, 22:09
-
Oli Bartsch commented on patch set 5 03/24/22, 22:09
ArrayDimensionMatcher.php:671ReplyDone -
Benni Mack voted on patch set 5 V +1 CR +1 03/24/22, 22:21
-
core-ci voted on patch set 5 V +1 03/24/22, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25118
-
Simon Schaufelberger commented on patch set 5 03/24/22, 23:25
ImageManipulationElement.php:200what about moving the code above the arguments? that would make it a bit easier for debugging instead of calling several functions when creating the arguments array. I would have even liked it to keep the method as before and only adjust the body. -
Oli Bartsch commented on patch set 5 03/25/22, 09:34
ImageManipulationElement.php:200ReplyHow would debugging be easier then? It's still possible to set a breakpoint to this line. I actually did exactly this while creating the patch. I also don't see the need for an extra method which just returns this statement. -
Jochen Roth voted on patch set 5 V +1 CR +1 03/25/22, 10:51
-
Stefan Bürk voted on patch set 5 V +1 CR +1 03/25/22, 11:09
-
Oli Bartsch voted on patch set 5 V +2 CR +2 03/25/22, 11:16
-
Oli Bartsch merged patch set 6 03/25/22, 11:16