Review main Merged Breaking

74026[!!!][FEATURE] Add PSR-14 Events for modifying inline element controls

Oli Bartsch CR +2 V +2 Hard +551 −51 updated 03/24/22, 19:46

Commit message

This introduces two new PSR-14 events, enabling
extension authors to modify the enabled controls as
well as the corresponding controls' markup for
FormEngine inline elements.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tceforms_inline.php']['tceformsInlineHook']
which is therefore now removed.

The hook required implementations to implement
the InlineElementHookInterface, which is now
deprecated as it's unused due to the hook removal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 914

  1. Oli Bartsch uploaded patch set 1 03/23/22, 17:08

  2. Oli Bartsch uploaded patch set 2 03/23/22, 17:21

  3. core-ci voted on patch set 1 V -1 03/23/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25081

  4. core-ci voted on patch set 2 V -1 03/23/22, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25084

  5. Oli Bartsch uploaded patch set 3 03/23/22, 17:31

  6. core-ci voted on patch set 3 V +1 03/23/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25085

  7. Oli Bartsch uploaded patch set 4 03/23/22, 22:38

  8. core-ci voted on patch set 4 V +1 03/23/22, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25088

  9. Nikita Hovratov uploaded patch set 5 03/24/22, 18:21

  10. Nikita Hovratov commented on patch set 5 V +1 CR +1 03/24/22, 18:21

    clean
  11. core-ci voted on patch set 5 V +1 03/24/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25111

  12. Benni Mack voted on patch set 5 V +1 CR +1 03/24/22, 19:28

  13. Oli Bartsch voted on patch set 5 V +2 CR +2 03/24/22, 19:46

  14. Oli Bartsch merged patch set 6 03/24/22, 19:46