Review main Merged

74027[FEATURE] Introduce TCA type "datetime"

Oli Bartsch CR +2 V +2 Expert +984 −577 updated 03/30/22, 08:50

Commit message

In our process of using dedicated TCA types,
the new TCA type "date" is introduced and
replaces "renderType=inputDateTime" of TCA
type "input".

Notable changes to the previous behaviour:

- the "format" option, which was already documented
  but never used in FormEngine, is now mandatory
- TCA option "max" is no longer evaluated
- The only allowed eval's are "null" and "int"

The corresponding FormEngine element class is
renamed from InputDateTimeElement to DatetimeElement.
This is covered in the ClassAliasMap.

Note: The "eval=int" seems to be superfluous since
the field value should always be stored as int in
case no native type ("dbType") is used. However,
this would be breaking and is therefore done in
a separate followup patch. This has already been
kickstarted in https://review.typo3.org/c/Packages/TYPO3.CMS/+/74027/12.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 55

Show 35 more files

Review log 2644

Show 1019 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/24/22, 09:12

  2. core-ci voted on patch set 1 V -1 03/24/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25093

  3. Oli Bartsch uploaded patch set 2 03/24/22, 19:45

  4. core-ci voted on patch set 2 V -1 03/24/22, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25113

  5. Oli Bartsch uploaded patch set 3 03/24/22, 21:28

  6. core-ci voted on patch set 3 V -1 03/24/22, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25116

  7. Oli Bartsch uploaded patch set 4 03/25/22, 09:13

  8. core-ci voted on patch set 4 V -1 03/25/22, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25127

  9. Oli Bartsch uploaded patch set 5 03/25/22, 13:41

  10. core-ci voted on patch set 5 V -1 03/25/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25138

  11. Oli Bartsch uploaded patch set 6 03/25/22, 14:52

  12. core-ci voted on patch set 6 V -1 03/25/22, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25143

  13. Oli Bartsch uploaded patch set 7 03/25/22, 17:17

  14. core-ci voted on patch set 7 V -1 03/25/22, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25148

  15. Oli Bartsch uploaded patch set 8 03/25/22, 22:00

  16. core-ci voted on patch set 8 V -1 03/25/22, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25163

  17. Oli Bartsch uploaded patch set 9 03/25/22, 23:32

  18. core-ci voted on patch set 9 V -1 03/25/22, 23:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25167

  19. Oli Bartsch uploaded patch set 10 03/25/22, 23:54

  1. core-ci voted on patch set 10 V -1 03/26/22, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25168

  2. Benni Mack commented on patch set 10 03/28/22, 11:11

    DataMapProcessor.php:1448

    I think this should not be handled here (do not prefix a label for a date time). By the way, the longer I htink of it. $type === link shouln't be used here either.
  3. Benni Mack commented on patch set 10 03/28/22, 11:12

    fe_users.php:262

    should be readOnly
  4. Oli Bartsch uploaded patch set 11 03/28/22, 14:13

  5. core-ci voted on patch set 11 V -1 03/28/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25214

  6. Oli Bartsch commented on patch set 11 03/28/22, 14:52

    DataMapProcessor.php:1448 Reply

    Done

    fe_users.php:262 Reply

    Done
  7. Oli Bartsch uploaded patch set 12 03/28/22, 15:10

  8. core-ci voted on patch set 12 V -1 03/28/22, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25219

  9. Oli Bartsch uploaded patch set 13 03/28/22, 20:50

  10. core-ci voted on patch set 13 V -1 03/28/22, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25233

  11. Oli Bartsch uploaded patch set 14 03/28/22, 22:00

  12. core-ci voted on patch set 14 V +1 03/28/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25237

  13. Oli Bartsch uploaded patch set 15 03/28/22, 23:37

  14. Oli Bartsch commented on patch set 15 03/28/22, 23:38

    This change is ready for review.
  15. core-ci voted on patch set 15 V +1 03/28/22, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25238

  16. Oli Bartsch uploaded patch set 16 03/29/22, 12:45

  17. core-ci voted on patch set 16 V +1 03/29/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25260

  18. Benni Mack voted on patch set 16 V +1 CR +1 03/29/22, 20:24

  19. Nikita Hovratov uploaded patch set 17 03/30/22, 07:53

  20. core-ci voted on patch set 17 V +1 03/30/22, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25279

  21. Nikita Hovratov uploaded patch set 18 03/30/22, 08:06

  22. core-ci voted on patch set 18 V +1 03/30/22, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25280

  23. Nikita Hovratov voted on patch set 18 V +1 CR +1 03/30/22, 08:25

  24. Benni Mack voted on patch set 18 V +2 CR +2 03/30/22, 08:50

  25. Benni Mack merged patch set 19 03/30/22, 08:50