74030[!!!][TASK] Remove global jquery object window.$
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 13
- Build/Sources/TypeScript/recordlist/recordlist.ts+3 −3
- Build/util/cjs-to-esm.js+2 −3
- Build/Gruntfile.js+2 −12
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97243-RemoveGlobalJQueryAccessViaWindow.rstnew+41 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileStorageTreeFilterCest.php+5 −7
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+4 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/AbstractCest.php+1 −3
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+5 −5
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageTreeFilterCest.php+7 −9
- typo3/sysext/recordlist/Resources/Public/JavaScript/recordlist.js+1 −1
Review log 1418
-
Benjamin Franzke uploaded patch set 1 03/25/22, 07:46
-
core-ci voted on patch set 1 V -1 03/25/22, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25122
-
Benjamin Franzke uploaded patch set 2 03/25/22, 09:07
-
core-ci voted on patch set 2 V +1 03/25/22, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25125
-
Benjamin Franzke uploaded patch set 3 03/28/22, 08:45
-
core-ci voted on patch set 3 V +1 03/28/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25202
-
Benni Mack voted on patch set 3 V +1 CR +1 03/28/22, 10:03
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/28/22, 12:16
-
Andreas Kienast commented on patch set 3 CR +1 03/28/22, 12:24
Looks good by reading, but I want go give it a try later.This paragraph somehow tells the same as the first one. -
Andreas Kienast updated the commit message in patch set 4 03/28/22, 15:47
-
Andreas Kienast voted on patch set 4 V +1 CR +1 03/28/22, 15:47
-
Christian Kuhn voted on patch set 4 V +1 CR +1 03/28/22, 15:50
-
Christian Kuhn commented on patch set 4 03/28/22, 15:50
Reply
Done -
core-ci voted on patch set 4 V +1 03/28/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25221
-
Benni Mack voted on patch set 4 V +1 CR +1 03/28/22, 16:43
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 03/28/22, 18:50
-
Benjamin Franzke merged patch set 5 03/28/22, 18:50
-
Benjamin Franzke commented on patch set 5 03/28/22, 19:07
Reply
Thanks for updating the patch. This slipped through while copying texts back from the RST file.