Review main Merged Breaking

74030[!!!][TASK] Remove global jquery object window.$

Benjamin Franzke CR +2 V +2 Normal +77 −52 updated 03/28/22, 19:07

Commit message

The global window.$ accessor to the jQuery instance is now
no longer provided.
Global jQuery usage has been deprecated in #86438 with the
suggestion to use JavaScript modules instead. With the
integration of browser native ES6 modules jQuery should
now be loaded as a regular module.

Some remaining cases in acceptance test are removed.
$.active == 0 checks have been no-ops as jQuery.ajax
isn't used in those components anymore
(core AjaxRequest which uses fetch() is used instead),
therefore $.active always resolved to 0.
This reveals why the additional 0.5s timeout-hack had been
added there, the method is now explicitly marked as an
explicit timeout instead of a waiting-method.

Note that window.jQuery is still provided if the
bootstrap javascript module is loaded as bootstrap JS
needs to load jQuery from the global window object.
window.jQuery global will be removed once we drop
bootstrap jquery interop (which is another breaking change).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 1418

  1. Benjamin Franzke uploaded patch set 1 03/25/22, 07:46

  2. core-ci voted on patch set 1 V -1 03/25/22, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25122

  3. Benjamin Franzke uploaded patch set 2 03/25/22, 09:07

  4. core-ci voted on patch set 2 V +1 03/25/22, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25125

  5. Benjamin Franzke uploaded patch set 3 03/28/22, 08:45

  6. core-ci voted on patch set 3 V +1 03/28/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25202

  7. Benni Mack voted on patch set 3 V +1 CR +1 03/28/22, 10:03

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 03/28/22, 12:16

  9. Andreas Kienast commented on patch set 3 CR +1 03/28/22, 12:24

    Looks good by reading, but I want go give it a try later.
    This paragraph somehow tells the same as the first one.
  10. Andreas Kienast updated the commit message in patch set 4 03/28/22, 15:47

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 03/28/22, 15:47

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 03/28/22, 15:50

  13. Christian Kuhn commented on patch set 4 03/28/22, 15:50

    Reply

    Done
  14. core-ci voted on patch set 4 V +1 03/28/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25221

  15. Benni Mack voted on patch set 4 V +1 CR +1 03/28/22, 16:43

  16. Benjamin Franzke voted on patch set 4 V +2 CR +2 03/28/22, 18:50

  17. Benjamin Franzke merged patch set 5 03/28/22, 18:50

  18. Benjamin Franzke commented on patch set 5 03/28/22, 19:07

    Reply

    Thanks for updating the patch. This slipped through while copying texts back from the RST file.