Review main Abandoned

74031[TASK] Clear redirects via Install Tool

Georg Ringer CR 0 V 0 Easy +4 −0 updated 03/26/22, 08:38

Commit message

The Install Tool module "Clear Persistent Database Tables" is extended
to be able to clear the table "sys_redirect".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 03/25/22, 07:52

  2. Georg Ringer commented on patch set 1 03/25/22, 07:52

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/25/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25123

  4. Oli Bartsch commented on patch set 1 03/25/22, 09:18

    ClearTableService.php:47 Unresolved

    AFAICS those are sorted alphabetically. This should therefore go after "sys_preview". Should we also somehow improve the description to be not just one word?
  5. Stefan Bürk commented on patch set 1 CR -1 03/25/22, 11:18

    I think it is not good, or better to say the wrong way to add "sys_redirects" to that clear table things, because of several reasons: * sys_redirects are not comparable like "log", "history" and the other tables already available. * simply truncating it is a really destructive operation on a table which containts auto-added things but also editor/admin managed content * handling redirect clearings can be alread done with configure ttl for "auto created" redirects and end constraints * thers already a command for kepe redirects clean: bin/typo3 redirects:cleanup (https://docs.typo3.org/c/typo3/cms-redirects/main/en-us/Setup/Index.html#redirects-cleanup) The main point is, that this table falls more in the category of "pages/tt_content" instead of "session data", "log data" or "history" data.
  6. Stefan Bürk commented on patch set 1 03/25/22, 11:27

    Reply

    Mainly because this "truncates" that table and not only remove outdated or "deleted" records and so on.
  7. Oli Bartsch commented on patch set 1 03/25/22, 11:57

    Reply Unresolved

    ACK on that.
  8. Georg Ringer abandoned the change 03/26/22, 08:38