Review main Merged Breaking

74055[!!!][TASK] Drop bootstrap jQuery interface and window.jQuery

Benjamin Franzke CR +2 V +2 Normal +60 −14 updated 11/10/23, 07:32

Commit message

The bootstrap jQuery interfaces required a global window.jQuery
variable to be set. The jquery drop-in is dropped in order to
remove this non-optional jQuery dependency.

As a side effect the window.jQuery global is removed as well.
Note that global jQuery usage has already been deprecated in #86438
and removed in #97243 with the suggestion to use JavaScript modules
instead. window.jQuery was basically left in place for bootstrap to
operate and therefore only `window.$` was removed back then, while
`window.jQuery` stayed for the time being.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1320

  1. Benjamin Franzke uploaded patch set 1 03/25/22, 10:14

  2. core-ci voted on patch set 1 V -1 03/25/22, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25129

  3. Benjamin Franzke uploaded patch set 2 V -1 07/04/23, 12:03

  4. core-ci voted on patch set 2 V -1 07/04/23, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43377

  5. Benjamin Franzke uploaded patch set 3 V -1 08/31/23, 08:40

  6. core-ci voted on patch set 3 V -1 08/31/23, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46071

  7. Benjamin Franzke commented on patch set 3 08/31/23, 08:52

    Still cases left to be adapted: ``` Sources/TypeScript/backend/login-refresh.ts:123:24 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 123 this.$timeoutModal.modal(this.options.modalConfig); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:124:24 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 124 this.$timeoutModal.modal('show'); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:133:24 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 133 this.$timeoutModal.modal('hide'); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:140:30 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 140 this.$backendLockedModal.modal(this.options.modalConfig); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:141:30 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 141 this.$backendLockedModal.modal('show'); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:148:30 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 148 this.$backendLockedModal.modal('hide'); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:160:25 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 160 this.$loginForm.modal(this.options.modalConfig); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:161:25 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 161 this.$loginForm.modal('show'); ~~~~~ Sources/TypeScript/backend/login-refresh.ts:184:21 - error TS2339: Property 'modal' does not exist on type 'JQuery'. 184 this.$loginForm.modal('hide'); ~~~~~ Sources/TypeScript/backend/multi-step-wizard.ts:303:28 - error TS2339: Property 'carousel' does not exist on type 'JQuery'. 303 this.setup.$carousel.carousel('next'); ~~~~~~~~ Sources/TypeScript/backend/multi-step-wizard.ts:311:28 - error TS2339: Property 'carousel' does not exist on type 'JQuery'. 311 this.setup.$carousel.carousel('prev'); ~~~~~~~~ Sources/TypeScript/backend/wizard.ts:173:28 - error TS2339: Property 'carousel' does not exist on type 'JQuery'. 173 this.setup.$carousel.carousel('next'); ~~~~~~~~ ```
  8. Benjamin Franzke uploaded patch set 4 V -1 09/01/23, 13:47

  9. core-ci voted on patch set 4 V -1 09/01/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46138

  10. Benjamin Franzke marked it work in progress 09/01/23, 14:09

  11. Benjamin Franzke rebased onto patch set 5 V -1 09/01/23, 16:21

  12. core-ci voted on patch set 5 V +1 09/01/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46154

  13. Benjamin Franzke uploaded patch set 6 V +1 11/07/23, 09:42

    Rebase
  14. core-ci voted on patch set 6 V +1 11/07/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48683

  15. Benni Mack voted on patch set 6 V +1 CR +1 11/07/23, 09:55

  16. Benjamin Franzke commented on patch set 7 CR +1 V +1 11/07/23, 12:29

    Published edit on patch set 6.
  17. core-ci voted on patch set 7 V +1 11/07/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48688

  18. Benni Mack voted on patch set 7 V +1 CR +1 11/07/23, 16:27

  19. Andreas Kienast voted on patch set 7 V +2 CR +2 11/10/23, 07:32

  20. Andreas Kienast merged patch set 8 11/10/23, 07:32