Review main Merged

74056[BUGFIX] Upgrade to CKEditor4 v4.18.0

Oliver Hader CR +2 V +2 Nightmare +1554 −2032 updated 03/26/22, 22:08

Commit message

Recent CKEditor4 v4.18.0 addressed several vulnerabilities:
* CVE-2022-24728 (XSS via attributes & comments)
* CVE-2022-24729 (reDoS via Dialog Plugin API)
* see https://ckeditor.com/cke4/release/CKEditor-4.18.0 for details

Mentioned known vulnerabilities are not considered relevant for the
TYPO3 backend user interface. By-passing CKEditor's XSS protection
allows to persist malicious markup in database fields, which is
mitigated during frontend rendering by typo3/html-sanitizer.

That's why this issue is handled as regular bugfix.

Executed commands:
  cd Build/
  nvm use
  yarn add ckeditor4@^4.18.0
  rm -r ../typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/
  yarn exec grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 790

Show 770 more files

Review log 56

  1. Oliver Hader uploaded patch set 1 03/25/22, 10:23

  2. core-ci voted on patch set 1 V +1 03/25/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25130

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/25/22, 12:34

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/25/22, 13:33

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/26/22, 22:08

  6. Benni Mack merged patch set 2 03/26/22, 22:08