Review main Merged

74064[TASK] Unify modal button style

Simon Schaufelberger CR +2 V +2 Easy +2 −2 updated 03/28/22, 22:32

Commit message

Creating new content is usually confirmed with a blue button.
This is inconsistent with the dashboard, which uses an orange button.
This patch changes the orange button to a blue one to be consistent.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Simon Schaufelberger uploaded patch set 1 03/26/22, 01:35

  2. core-ci voted on patch set 1 V +1 03/26/22, 01:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25171

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/26/22, 08:43

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/27/22, 15:41

  5. Björn Jacob commented on patch set 1 03/28/22, 05:42

    Thanks for working on this one. How do we proceed with the other modals? Do we need additional tickets for it?
  6. Christian Kuhn commented on patch set 1 03/28/22, 11:39

    Yeah. Let's handle the others in dedicated issues / patches and set the main issue as related.
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 03/28/22, 11:39

  8. Christian Kuhn merged patch set 2 03/28/22, 11:39

  9. Simon Schaufelberger commented on patch set 2 03/28/22, 22:32

    Other issues exist already: https://forge.typo3.org/issues/85144