Review main Merged

74065[BUGFIX] Remove double encoding and improve template

Simon Schaufelberger CR +2 V +2 Easy +9 −8 updated 03/29/22, 06:55

Commit message

The contents of the column "Record" in the Recycler are escaped/encoded
twice with htmlspecialchars. This leads to the display of & when the
text contains an ampersand. Additionally some spacing was added next to
the user avatar in the collapsed row.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Simon Schaufelberger uploaded patch set 1 03/26/22, 13:38

  2. Simon Schaufelberger updated the commit message in patch set 2 03/26/22, 13:39

  3. Simon Schaufelberger commented on patch set 2 03/26/22, 13:45

    RecyclerAjaxController.php:182

    In v10 this is in DeletedRecordsController
  4. core-ci voted on patch set 1 V +1 03/26/22, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25177

  5. core-ci voted on patch set 2 V +1 03/26/22, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25178

  6. Christian Kuhn commented on patch set 2 03/28/22, 15:49

    fine with me and +1 on testing. just removing v10 since this is imho not a critical bug.

    RecyclerAjaxController.php:182 Reply

    Done
  7. Christian Kuhn updated the commit message in patch set 3 03/28/22, 15:49

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 03/28/22, 15:49

  9. core-ci voted on patch set 3 V +1 03/28/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25222

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 03/28/22, 16:25

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 03/29/22, 06:53

  12. Christian Kuhn merged patch set 4 03/29/22, 06:55