74067[FEATURE] Introduce TCA type "number"
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 38
- Build/Sources/TypeScript/backend/form-engine/field-wizard/value-slider.ts+40 −22
- Build/Sources/TypeScript/backend/form-engine-validation.ts+5 −3
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+3 −0
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+2 −52
- typo3/sysext/backend/Classes/Form/Element/NumberElement.php2new+309 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessPlaceholders.php+2 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+2 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −0
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+6 −8
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-wizard/value-slider.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+48 −27
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+62 −0
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −1
- typo3/sysext/core/Configuration/TCA/sys_file.php+1 −3
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+2 −6
Show 18 more files
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+2 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97193-NewTCATypeNumber.rstnew+134 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputEvalCest.php+0 −75
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicNumberCest.phpnew+154 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TCA/tx_testirrecsv_price.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TCA/tx_testirreforeignfield_price.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mm/Configuration/TCA/tx_testirremm_price.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_price.php+2 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+69 −49
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+171 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/extensionmanager/Configuration/TCA/tx_extensionmanager_domain_model_extension.php+2 −4
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php+3 −9
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+2 −4
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+1 −3
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php4+9 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+6 −8
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php2+1 −2
Review log 3247
Show 1222 earlier messages
-
Nikita Hovratov uploaded patch set 1 03/28/22, 11:07
-
Nikita Hovratov marked it work in progress 03/28/22, 11:10
-
core-ci voted on patch set 1 V -1 03/28/22, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25210
-
Nikita Hovratov uploaded patch set 2 03/30/22, 09:44
-
core-ci voted on patch set 2 V -1 03/30/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25282
-
Nikita Hovratov uploaded patch set 3 03/30/22, 10:11
-
core-ci voted on patch set 3 V -1 03/30/22, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25283
-
Nikita Hovratov uploaded patch set 4 03/30/22, 10:43
-
core-ci voted on patch set 4 V -1 03/30/22, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25285
-
Nikita Hovratov uploaded patch set 5 03/30/22, 11:30
-
core-ci voted on patch set 5 V -1 03/30/22, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25286
-
Nikita Hovratov uploaded patch set 6 03/30/22, 12:23
-
core-ci voted on patch set 6 V -1 03/30/22, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25287
-
Nikita Hovratov uploaded patch set 7 03/30/22, 14:57
-
core-ci voted on patch set 7 V -1 03/30/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25289
-
Nikita Hovratov uploaded patch set 8 03/30/22, 16:10
-
core-ci voted on patch set 8 V -1 03/30/22, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25291
-
Nikita Hovratov uploaded patch set 9 03/30/22, 16:31
-
core-ci voted on patch set 9 V -1 03/30/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25293
-
Nikita Hovratov uploaded patch set 10 03/30/22, 16:53
-
core-ci voted on patch set 10 V +1 03/30/22, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25294
-
Nikita Hovratov commented on patch set 10 03/30/22, 17:03
This change is ready for review.
-
Benni Mack commented on patch set 10 03/30/22, 20:49
QueryGenerator.php:992looks like ... doubled? if $fields['type'] == number then $fields['type'] = number -
Oli Bartsch uploaded patch set 11 04/01/22, 13:27
-
core-ci voted on patch set 11 V +1 04/01/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25354
-
Nikita Hovratov commented on patch set 11 04/03/22, 19:42
QueryGenerator.php:992ReplyTechnically yes, but it's the same name by coincidence. We need at least the break statement, or it will fall back to "text". So I would say, we write it this way to be more explicit. -
Andreas Kienast commented on patch set 11 04/04/22, 10:33
QueryGenerator.php:992ReplyI think you can just drop the assignment here and leave the break as is, with a comment -
Andreas Kienast commented on patch set 11 04/04/22, 10:43
NumberElement.php:127[EA] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options. -
Andreas Kienast commented on patch set 11 CR -1 04/04/22, 10:48
on it -
Andreas Kienast uploaded patch set 12 04/04/22, 10:56
-
Andreas Kienast voted on patch set 12 V +1 CR +1 04/04/22, 10:57
-
core-ci voted on patch set 12 V +1 04/04/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25394
-
Oli Bartsch commented on patch set 12 CR -1 04/04/22, 13:50
On it -
Oli Bartsch uploaded patch set 13 04/04/22, 22:10
-
Oli Bartsch commented on patch set 13 CR -1 04/04/22, 22:10
Still on it -
core-ci voted on patch set 13 V -1 04/04/22, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25460
-
Oli Bartsch uploaded patch set 14 04/05/22, 12:02
-
Oli Bartsch commented on patch set 14 04/05/22, 12:05
NumberElement.php:127ReplyDoneQueryGenerator.php:992ReplyDone -
Benni Mack commented on patch set 14 04/05/22, 12:07
sys_workspace.php:118I mean, do we need this size field? Imagine a size=50, doesn't seem like a "useful" option for people to configure. -
Benni Mack commented on patch set 14 04/05/22, 12:12
sys_workspace.php:118ReplyOK. Let's leave it as is for the time being (just like with the other new types) -
core-ci voted on patch set 14 V +1 04/05/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25503
-
Nikita Hovratov uploaded patch set 15 04/05/22, 14:21
-
Nikita Hovratov commented on patch set 15 V +1 CR +1 04/05/22, 14:25
Thanks a lot Oli! -
core-ci voted on patch set 15 V +1 04/05/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25513
-
Oli Bartsch commented on patch set 15 04/05/22, 14:43
Corresponding styleguide change https://github.com/TYPO3/styleguide/pull/316 -
Andreas Kienast voted on patch set 15 V +2 CR +2 04/05/22, 15:25
-
Andreas Kienast merged patch set 16 04/05/22, 15:25