74072[BUGFIX] Load property from real instance
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2022
-
Simon Schaufelberger uploaded patch set 1 03/28/22, 19:59
-
Simon Schaufelberger commented on patch set 1 03/28/22, 20:00
This code is NOT from me but from Alexander Schnitzler who came up with the solution. I just uploaded it to gerrit. -
core-ci voted on patch set 1 V +1 03/28/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25231
-
Oli Bartsch commented on patch set 1 03/29/22, 00:03
Reply
So, should we then set the author correctly, since this comment won't show up in the git history. -
Christian Kuhn commented on patch set 1 03/29/22, 07:21
i'd argue we should remove v10 here: fixing this in v10 may have the 'unexpected' result that some models now validate properly ... which is of course correct, but i fear this may break something. since that patch is buried so deep in the system and is not trivial, i'm not sure if we should really keep v10 here, so i'd rather drop v10: existing instances under active v10 development should either pick the patch on their own if they suffer from the bug, or upgrade to v11. removing v10 from the backport list then does not add the risk to break something in non-active development v10 instances ... -
Christian Kuhn updated the commit message in patch set 2 03/29/22, 07:21
-
Christian Kuhn voted on patch set 2 CR +1 03/29/22, 07:21
-
core-ci voted on patch set 2 V +1 03/29/22, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25243
-
Simon Schaufelberger commented on patch set 2 03/29/22, 08:53
Reply
same is true for v11, that is why I would like to backport it for v10 as well and not only v11. I guess there are many v11 installations out there already with the same problem. if you have xclassed v10, this won't affect you anyway. -
Oliver Klee voted on patch set 2 CR +1 03/29/22, 10:02
-
Christian Kuhn commented on patch set 2 03/29/22, 10:20
Reply
right. but with v11 it's much more likely the instance is still in active development and for v10 people probably worked around that already ... and i don't feel to good with taking the responsibility to merge this into v10 ... could you somehow live with main & v11 only? -
Georg Ringer voted on patch set 2 V +1 CR +1 03/29/22, 10:45
-
Simon Schaufelberger commented on patch set 2 03/29/22, 10:48
Reply
as written in the issue itself, a workaround is to set the properties public, then symfony is also able to access the property. I really don't see any reason why this should break some installation and if it does, it's probably one in a million 😅 -
Oli Bartsch commented on patch set 2 03/29/22, 10:48
Reply
? -
Simon Schaufelberger commented on patch set 2 03/29/22, 10:53
8 people are watching this issue. that's not much. I guess they will be happy about the official solution and that they can get rid of their xclass hack. -
Christian Kuhn commented on patch set 2 03/29/22, 10:56
Reply
well, simon pushed it and takes care of getting it through. imho fine to keep him as author on it. -
Simon Schaufelberger commented on patch set 2 03/29/22, 11:01
Reply
can you do that within Gerrit or do I need to re-upload another commit? -
Christian Kuhn commented on patch set 2 03/29/22, 11:16
Reply
afaik not possible via interface ... and: just keep youselfs as author ... -
Torben Hansen commented on patch set 2 03/29/22, 11:22
Reply
I use this fix via XClass in a v10 production instance without any problems. But I'm also fine if this only gets fixed officially in v11 + main -
Torben Hansen voted on patch set 2 V +1 CR +1 03/29/22, 11:27
-
Christian Kuhn voted on patch set 2 V +2 CR +2 03/29/22, 11:49
-
Christian Kuhn merged patch set 3 03/29/22, 11:49