7409[TASK] Invalid SQL and bad code in tslib_fe
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Susi Moog +1
-
Verified V +2
- Tolleiv Nietsch +2
- Steffen Ritter +2
- Susi Moog +1
Issues 1
Files 1
Review log 11
-
Stefan Neufeind commented on patch set 2 03/12/12, 16:25
Looks good to me, but someone else must approve straight backport from masterclass.tslib_fe.php:4895unneeded whitespace-change? -
Markus Klein uploaded patch set 2 03/12/12, 16:25
-
Tolleiv Nietsch commented on patch set 3 V 0 03/12/12, 16:25
by team member; Looks good to me, approved -
Stefan Neufeind commented on patch set 3 03/12/12, 16:25
Looks good to me, but someone else must approve -
Susi Moog commented on patch set 3 03/12/12, 16:25
Verified; Looks good to me, but someone else must approve Previous patch set threw a fatal error because t3lib_utility_math does not exist in 4.5. -
Susi Moog uploaded patch set 3 03/12/12, 16:25
-
Bart Dubelaar commented on patch set 2 03/12/12, 16:25
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 2 03/12/12, 16:25
(1 inline comment)class.tslib_fe.php:4895Replythere is no new line after ">" so it is correct. Before there WAS a new line! -
Wouter Wolters commented on patch set 3 03/12/12, 16:25
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 3 V 0 03/12/12, 16:25
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 3 03/12/12, 16:25