Review TYPO3_4-5 Merged

7409[TASK] Invalid SQL and bad code in tslib_fe

Markus Klein CR +2 V +2 Easy +21 −7 updated 06/03/13, 20:49

Commit message

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Susi Moog +1

Issues 1

Files 1

Review log 11

  1. Stefan Neufeind commented on patch set 2 03/12/12, 16:25

    Looks good to me, but someone else must approve straight backport from master

    class.tslib_fe.php:4895

    unneeded whitespace-change?
  2. Markus Klein uploaded patch set 2 03/12/12, 16:25

  3. Tolleiv Nietsch commented on patch set 3 V 0 03/12/12, 16:25

    by team member; Looks good to me, approved
  4. Stefan Neufeind commented on patch set 3 03/12/12, 16:25

    Looks good to me, but someone else must approve
  5. Susi Moog commented on patch set 3 03/12/12, 16:25

    Verified; Looks good to me, but someone else must approve Previous patch set threw a fatal error because t3lib_utility_math does not exist in 4.5.
  6. Susi Moog uploaded patch set 3 03/12/12, 16:25

  7. Bart Dubelaar commented on patch set 2 03/12/12, 16:25

    Looks good to me, but someone else must approve
  8. Simon Schaufelberger commented on patch set 2 03/12/12, 16:25

    (1 inline comment)

    class.tslib_fe.php:4895 Reply

    there is no new line after ">" so it is correct. Before there WAS a new line!
  9. Wouter Wolters commented on patch set 3 03/12/12, 16:25

    Looks good to me, but someone else must approve
  10. Steffen Ritter commented on patch set 3 V 0 03/12/12, 16:25

    by team member; Looks good to me, approved
  11. Steffen Ritter merged patch set 3 03/12/12, 16:25