Review TYPO3_4-6 Merged

7410[TASK] Invalid SQL and bad code in tslib_fe

Markus Klein CR +2 V +2 Easy +20 −6 updated 06/03/13, 20:49

Commit message

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 3

  1. Stefan Neufeind commented on patch set 1 02/27/12, 19:26

    Looks good to me, but someone else must approve straight backport from master
  2. Xavier Perseguers commented on patch set 1 V 0 02/27/12, 19:26

    by team member; Looks good to me, approved Backport from master
  3. Xavier Perseguers merged patch set 1 02/27/12, 19:26