Review main Merged

74112[BUGFIX] Adjust password field acceptance test

Stefan Bürk CR +2 V +2 Normal +85 −12 updated 03/29/22, 09:29

Commit message

In ext:styleguide the old password field 'input_16'
has been removed, while new passwords fields, using
the new "password" TCA type, were added in a dedicated
tab to showcase #97104.

Therefore, the 'input_16' check is removed from
ElementsBasicInputSimpleCest and the dedicated
ElementsBasicPasswordCest is added, checking the
new password fields (with the "password" TCA type).

Done steps:

* updated styleguide to have min commit hash available
* removed input_16 field test from ElementsBasicInputSimpleCest
* added ElementsBasicPasswordCest with 'password_2' field as
  direct replacement for 'input_16' test. Further tests may be
  added later on.

used commands:

> composer u typo3/cms-styleguide

Related styleguide change:
https://github.com/TYPO3/styleguide/commit/31f6d4b5886e2d6403b4bea7fb7decbc73bab901

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 69

  1. Stefan Bürk uploaded patch set 1 03/29/22, 08:36

  2. core-ci voted on patch set 1 V +1 03/29/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25247

  3. Stefan Bürk commented on patch set 1 03/29/22, 08:48

  4. Oli Bartsch uploaded patch set 2 03/29/22, 08:55

  5. core-ci voted on patch set 2 V +1 03/29/22, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25249

  6. core-ci voted on patch set 1 V +1 03/29/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25248

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 03/29/22, 09:19

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/29/22, 09:29

  9. Anja Leichsenring merged patch set 3 03/29/22, 09:29