Review 11.5 Merged

74116[BUGFIX] Ensure imageLinkWrap works with UTF-8 filenames

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 03/29/22, 10:43

Commit message

The unset($info['originalFile']) introduced in #90565
broke an access to that array key below in the method.
This leads to the situation that files with UTF-8
characters are not found anymore since the imageLinkWrap()
method is fed with an encoded version of the filename
and not the original file object anymore.
The patch parks $info['originalFile'] in a variable
to access it for imageLinkWrap() again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 03/29/22, 10:33

  2. core-ci voted on patch set 1 V +1 03/29/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25256

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/29/22, 10:43

  4. Christian Kuhn merged patch set 2 03/29/22, 10:43