74119[FEATURE] Add Luxembourgish (lb) as supported language
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Chris Müller +1
-
Verified V +2 Done
- Oli Bartsch +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1621
-
Stefan Bürk uploaded patch set 1 03/29/22, 14:29
-
core-ci voted on patch set 1 V +1 03/29/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25262
-
Oli Bartsch commented on patch set 1 03/29/22, 14:46
Usually, we introduce new languages as feature, see e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/69673 for "welsh" or https://review.typo3.org/c/Packages/TYPO3.CMS/+/68987 for "shona". -
Stefan Bürk commented on patch set 1 03/29/22, 14:47
Reply
Was not aware of this. Will change this to a feature and v12 then. -
Stefan Bürk uploaded patch set 2 03/29/22, 15:22
-
Stefan Bürk uploaded patch set 3 03/29/22, 15:22
-
core-ci voted on patch set 3 V +1 03/29/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25265
-
core-ci voted on patch set 2 V +1 03/29/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25264
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/29/22, 18:03
-
Benni Mack commented on patch set 3 03/29/22, 22:15
Should "lb" have a fallback to "de" (in Locales->localeDependencies) since it is based on West German? -
Stefan Bürk commented on patch set 3 03/29/22, 23:22
Reply
Not sure about how localeDependencies is working (or meant to work). In the end Luxemburg has 3 official languages: ``` lb => lb lb_LU => lb de_LU => de fr_LU => fr ``` So with fallback you mean, that if no "lb" language translation is provided, it should use "de" ? And that what Locales->localeDependencies is for ? -
Benni Mack commented on patch set 3 03/30/22, 08:55
Reply
If you don't have a label defined in lb.locallang.xlf, it will check de.locallang.xlf before falling back to locallang.xlf -
Stefan Bürk uploaded patch set 4 03/30/22, 10:27
-
core-ci voted on patch set 4 V +1 03/30/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25284
-
Oli Bartsch voted on patch set 4 V +1 CR +1 03/30/22, 14:23
-
Chris Müller uploaded patch set 5 03/30/22, 15:59
-
core-ci voted on patch set 5 V +1 03/30/22, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25290
-
Stefan Bürk commented on patch set 5 03/30/22, 16:40
Thx Chris -
Chris Müller voted on patch set 5 V +1 CR +1 03/30/22, 17:14
-
Oli Bartsch voted on patch set 5 V +2 CR +2 03/31/22, 08:41
-
Oli Bartsch merged patch set 6 03/31/22, 08:41