Review main Merged

74121[FEATURE] Introduce TCA type "color"

Oli Bartsch CR +2 V +2 Hard +537 −114 updated 04/01/22, 13:21

Commit message

In the process of using dedicated TCA types,
the new TCA type "color" is introduced and
replaces "renderType=colorpicker" of TCA
type "input".

Notable changes to the previous behaviour:

- The maxlength is set to 7, since this is
  the maximum length for the hex color
  (#XXXXX | /#[0-9a-fA-F]{3,6}/)
- The only allowed eval is "null"
- "trim" is always done in DataHandler and FormEngine

Note: The maxlength might change again
as soon as we switch to another color
picker which supports e.g. opacity
specification.

The TCA type is now wrapped into a custom
element. Also does it now use the general
ValuePicker JS module, instead of duplicating
this functionality in the ColorPicker JS module.

The ColorPicker JS module is furthermore
refactored. Global initialization of the
color pickers is deprecated. To initialize
the ColorPicker for an element, it has to
be provided as first argument in the
initialize() method.

used command:
> composer u typo3/cms-styleguide

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 1932

Show 47 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/29/22, 22:05

  2. core-ci voted on patch set 1 V -1 03/29/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25272

  3. Oli Bartsch uploaded patch set 2 03/29/22, 22:53

  4. core-ci voted on patch set 2 V -1 03/29/22, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25273

  5. Oli Bartsch uploaded patch set 3 03/30/22, 14:17

  6. core-ci voted on patch set 3 V +1 03/30/22, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25288

  7. Oli Bartsch uploaded patch set 4 03/31/22, 15:26

  1. core-ci voted on patch set 4 V +1 03/31/22, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25310

  2. Oli Bartsch uploaded patch set 5 03/31/22, 16:29

  3. core-ci voted on patch set 5 V +1 03/31/22, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25314

  4. Oli Bartsch uploaded patch set 6 03/31/22, 20:11

  5. core-ci voted on patch set 6 V +1 03/31/22, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25318

  6. Oli Bartsch rebased onto patch set 7 04/01/22, 08:34

  7. Oli Bartsch uploaded patch set 8 04/01/22, 08:34

  8. core-ci voted on patch set 7 V +1 04/01/22, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25327

  9. Oli Bartsch uploaded patch set 9 04/01/22, 08:47

  10. core-ci voted on patch set 8 V -1 04/01/22, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25328

  11. core-ci voted on patch set 9 V +1 04/01/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25330

  12. Stefan Bürk commented on patch set 9 04/01/22, 11:58

    Your wish is my command - running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/25348
  13. core-ci voted on patch set 9 V -1 04/01/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25348

  14. Stefan Bürk commented on patch set 9 04/01/22, 12:11

    Reply

    nightly cancel thus red - will rerun after typo3/cms-styleguide raise is added
  15. Oli Bartsch uploaded patch set 10 04/01/22, 12:11

  16. Benni Mack voted on patch set 10 V +1 CR +1 04/01/22, 12:15

  17. core-ci voted on patch set 10 V +1 04/01/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25350

  18. Stefan Bürk commented on patch set 10 CR -1 04/01/22, 12:21

  19. core-ci commented on patch set 10 04/01/22, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25351

  20. Stefan Bürk uploaded patch set 11 04/01/22, 13:02

  21. Stefan Bürk voted on patch set 11 V +1 CR +1 04/01/22, 13:03

  22. core-ci voted on patch set 11 V +1 04/01/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25353

  23. Benni Mack voted on patch set 11 V +1 CR +1 04/01/22, 13:16

  24. Oli Bartsch voted on patch set 11 V +2 CR +2 04/01/22, 13:21

  25. Oli Bartsch merged patch set 12 04/01/22, 13:21