Review 11.5 Merged

74138[TASK] Comment two symfony/rate-limiter related tests

Georg Ringer CR +2 V +2 Easy +6 −0 updated 04/04/22, 19:59

Commit message

symfony/rate-limiter:5.4.7 has a bug [1] leading to
E_DEPRECATED warnings in our functional rate limiting
tests. This is mostly test related so it does not
make much sense to set this version as conflict.

We'll comment two tests while waiting for a patch
level release 5.4.8.

[1] https://github.com/symfony/symfony/issues/45924

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 04/04/22, 19:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/04/22, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25456

  3. Georg Ringer voted on patch set 1 V +2 CR +2 04/04/22, 19:59

  4. Georg Ringer merged patch set 2 04/04/22, 19:59