Review 11.5 Merged

74142[BUGFIX] Explicitly use control characters in HTML fixture

Andreas Kienast CR +2 V +2 Hard +195 −196 updated 04/05/22, 15:32

Commit message

`RenderPreviewImportPageAndRecordsByUpdateWithDiff.php` has HTML markup
with line breaks and tab characters. With some IDEs this may break if
lines containing a tab only will get trimmed. All such characters are
now replaced by explicit control characters to make sure the expectation
does not break anymore when saving this file.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 04/05/22, 15:09

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/05/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25523

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/05/22, 15:32

  4. Andreas Kienast merged patch set 2 04/05/22, 15:32