Review 11.5 Merged

74145[BUGFIX] Fix exception in filelist when nullable columns are shown

Oli Bartsch CR +2 V +2 Easy +2 −3 updated 04/07/22, 10:08

Commit message

When nullable columns are shown in filelist module, an
exception is thrown, because null may be passed to
htmlspecialchars().

This change ensures that an empty string is passed to
htmlspecialchars(), if the column value is null. Also
the last parameter from the getProcessedValueExtra()
function call is removed, since it equals the functions
default value for the $forceResult parameter.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Oli Bartsch commented on patch set 1 04/06/22, 13:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 04/06/22, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25648

  3. core-ci voted on patch set 1 V +1 04/06/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25648

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 04/07/22, 10:08

  5. Oli Bartsch merged patch set 2 04/07/22, 10:08