Review main Merged

74152[TASK] Move workspaces data handling tests to core

Christian Kuhn CR +2 V +2 Expert +465 −1043 updated 04/04/22, 14:03

Commit message

The ext:core and ext:workspaces data scenario functional
tests are pairs: core comes with the 'Modify' scenarios
and workspaces extends them with own 'Discard', 'Modify',
'Publish' and 'PublishAll' ones.

The patch separates the ext:core 'Modify' scenarios
into an own directory and moves the ext:workspaces
pendants next to it. This gives better overview and
makes more clear that most of the workspaces related
handling is part of ext:core anyways.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1032

Show 1012 more files

Review log 1318

  1. Christian Kuhn uploaded patch set 1 03/31/22, 21:32

  2. core-ci voted on patch set 1 V -1 03/31/22, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25319

  3. Christian Kuhn uploaded patch set 2 03/31/22, 21:42

  4. Christian Kuhn updated the commit message in patch set 3 03/31/22, 21:46

  5. Christian Kuhn commented on patch set 3 03/31/22, 21:50

    note there is a lot of renaming and file moving in this patch for functional tests. CI still runs 5704 functional tests both with and without the patch, so we can be rather confident that we didn't looses tests along the way.
  6. core-ci voted on patch set 3 V +1 03/31/22, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25321

  7. core-ci voted on patch set 2 V +1 03/31/22, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25320

  8. Christian Kuhn updated the commit message in patch set 4 03/31/22, 22:01

  9. core-ci voted on patch set 4 V +1 03/31/22, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25322

  10. Stefan Bürk commented on patch set 4 CR -1 04/01/22, 10:11

    reading ...
  11. Stefan Bürk commented on patch set 4 V +1 CR +1 04/01/22, 11:47

    For sure - backports with tests in these are will become hard then ;)
  12. Christian Kuhn uploaded patch set 5 04/04/22, 09:27

  13. core-ci voted on patch set 5 V +1 04/04/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25391

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 04/04/22, 10:46

  15. Andreas Kienast commented on patch set 5 04/04/22, 11:17

    AbstractDataHandlerActionTestCase.php:52

    should we use `protected ?int $expectedErrorLogEntries` here?
  16. Christian Kuhn commented on patch set 5 04/04/22, 14:01

    AbstractDataHandlerActionTestCase.php:52 Reply

    not with this patch, please: this is basically a move / copy patch that keeps code. in general i'd actually strive to fully get rid of this log-test, or solve it differently - it's also used in just a couple of places.
  17. Andreas Kienast commented on patch set 5 V +2 CR +2 04/04/22, 14:03

    AbstractDataHandlerActionTestCase.php:52 Reply

    Ack
  18. Andreas Kienast merged patch set 6 04/04/22, 14:03