Review main Merged

74161[BUGFIX] Show correct creation and modification time in filelist

Oli Bartsch CR +2 V +2 Easy +12 −5 updated 04/05/22, 08:25

Commit message

The creation and modification time of files
is now displayed correctly again, using the
file info instead of the file metadata values.
Especially when sorting by those fields, this
previously led to discrepancies since the driver
(performing the sorting) always uses the file
info. See related patch:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/74158

Additionally, non-admins are now also able
to select the creation and modification time
"fields" in the column selector.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. Oli Bartsch uploaded patch set 1 04/04/22, 12:05

  2. core-ci voted on patch set 1 V +1 04/04/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25397

  3. Oli Bartsch voted on patch set 1 V -1 04/04/22, 12:23

  4. Oli Bartsch uploaded patch set 2 04/04/22, 13:23

  5. core-ci voted on patch set 2 V +1 04/04/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25412

  6. Susi Moog commented on patch set 2 04/04/22, 14:07

    ColumnSelectorController.php:207

    why can't we add the two fields to exclude_file_fields and avoid the consecutive array_merges?
  7. Oli Bartsch commented on patch set 2 04/04/22, 14:18

    ColumnSelectorController.php:207 Reply

    I fear I don't fully understand your question. This line is always necessary to dynamically add the resolved $fileFields to the exclude fields list. If we would add "crdate" and "tstamp" to the constant, we could remove the array_unique() but not this line.
  8. Susi Moog commented on patch set 2 CR +1 04/04/22, 14:50

    ColumnSelectorController.php:207 Reply

    yes, because I wasn't thinking straight, sorry - never mind me, misunderstood the line.
  9. Susi Moog voted on patch set 2 V +1 04/04/22, 14:58

  10. Oli Bartsch updated the commit message in patch set 3 04/04/22, 15:08

  11. Oli Bartsch commented on patch set 3 04/04/22, 15:08

    ColumnSelectorController.php:207 Reply

    Done
  12. Susi Moog voted on patch set 3 V +1 CR +1 04/04/22, 15:13

  13. core-ci voted on patch set 3 V +1 04/04/22, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25426

  14. Stefan Bürk voted on patch set 3 CR +1 04/04/22, 18:22

  15. Stefan Bürk voted on patch set 3 V +1 04/04/22, 18:33

  16. Christian Kuhn voted on patch set 3 V +1 CR +1 04/05/22, 08:25

  17. Oli Bartsch voted on patch set 3 V +2 CR +2 04/05/22, 08:25

  18. Oli Bartsch merged patch set 4 04/05/22, 08:25