74162[FEATURE] Add methods to check if the assets already exist
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1927
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 04/04/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25398
-
core-ci voted on patch set 2 V +1 04/04/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25399
-
Andreas Kienast voted on patch set 2 CR +1 04/04/22, 13:58
-
Simon Schaufelberger commented on patch set 2 04/08/22, 00:07
-
Shehfinaz Kadavil uploaded patch set 3 04/08/22, 09:06
-
Shehfinaz Kadavil commented on patch set 3 04/08/22, 09:10
Hi, I have corrected the method name, please let me know if its ok. -
core-ci voted on patch set 3 V -1 04/08/22, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25819
-
Andreas Kienast commented on patch set 4 04/08/22, 09:42
Published edit on patch set 3. -
core-ci voted on patch set 4 V -1 04/08/22, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25822
-
Andreas Kienast uploaded patch set 5 04/08/22, 09:55
-
core-ci voted on patch set 5 V -1 04/08/22, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25824
-
Andreas Kienast commented on patch set 6 04/08/22, 10:15
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 04/08/22, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25825
-
Simon Schaufelberger commented on patch set 6 V +1 CR +1 04/08/22, 11:30
AssetCollector.php:228ReplyDone -
Stefan Bürk commented on patch set 6 CR -1 04/08/22, 18:44
Feature-91715-MakeNewAssetCollectorClassSearchable.rst:4"searchable" is a missleading description. AssetCollector do not get really searchable at all. Many developers may associate with searchable things like wildcard, like, placeholder, part search etc. This patch is all about adding a "has asset identifier set". So this should be rephrased to match more what this feature is about.Feature-91715-MakeNewAssetCollectorClassSearchable.rst:18We should add some code example here - which would make this feature more clearer than "words". -
Shehfinaz Kadavil uploaded patch set 7 04/14/22, 13:34
-
Stefan Bürk commented on patch set 7 CR -1 04/14/22, 13:40
on it -
Shehfinaz Kadavil commented on patch set 7 04/14/22, 13:41
Please check the changes and let me know if its ok.Feature-91715-MakeNewAssetCollectorClassSearchable.rst:4ReplyDoneFeature-91715-MakeNewAssetCollectorClassSearchable.rst:18ReplyDone -
core-ci voted on patch set 7 V +1 04/14/22, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26022
-
Stefan Bürk uploaded patch set 8 04/14/22, 14:27
-
Stefan Bürk commented on patch set 8 V +1 CR +1 04/14/22, 14:31
Thanks for this patch. -
Shehfinaz Kadavil commented on patch set 8 04/14/22, 14:32
Reply
Thanks for the patch :) -
core-ci voted on patch set 8 V +1 04/14/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26024
-
Benni Mack voted on patch set 8 V +2 CR +2 04/14/22, 20:27
-
Benni Mack merged patch set 9 04/14/22, 20:27
AssetCollector.php:228