74163[TASK] Use bootstrap badges instead of labels
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 51
- Build/Sources/Sass/module/_install.scss2+9 −9
- Build/Sources/Sass/typo3/_element_badges.scss+93 −8
- Build/Sources/Sass/typo3/_element_label.scssdeleted+0 −58
- Build/Sources/Sass/typo3/_element_tceforms.scss+0 −2
- Build/Sources/Sass/adminpanel.scss+2 −2
- Build/Sources/Sass/backend.scss+28 −29
- Build/Sources/Sass/_legacy.scss+0 −65
- Build/Sources/Sass/_minimal.scss+39 −39
- Build/Sources/TypeScript/backend/form-engine/element/mfa-info-element.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine.ts+4 −4
- Build/Sources/TypeScript/backend/online-media.ts+1 −1
- Build/Sources/TypeScript/install/module/environment/environment-check.ts+2 −2
- Build/Sources/TypeScript/install/module/upgrade/upgrade-docs.ts+1 −1
- Build/Sources/TypeScript/workspaces/backend.ts+3 −3
- Build/Gruntfile.js3+1 −6
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+4 −4
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+2 −2
Show 31 more files
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+3 −3
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/mfa-info-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/online-media.js+1 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+13 −13
- typo3/sysext/beuser/Classes/ViewHelpers/MfaStatusViewHelper.php+2 −2
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+1 −1
- typo3/sysext/beuser/Tests/Functional/ViewHelpers/MfaStatusViewHelperTest.php+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerShowVersionsTable.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerTable.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/List.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html+2 −2
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFolder.html+2 −2
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.html+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/environment-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-docs.js+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+2 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+6 −6
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- .stylelintrc+0 −13
Review log 1421
-
Benjamin Kott uploaded patch set 1 04/04/22, 12:25
-
core-ci voted on patch set 1 V -1 04/04/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25405
-
Andreas Kienast uploaded patch set 2 04/04/22, 13:47
-
Andreas Kienast uploaded patch set 3 04/04/22, 13:53
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/04/22, 13:53
-
core-ci voted on patch set 2 V +1 04/04/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25414
-
core-ci voted on patch set 3 V +1 04/04/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25415
-
Benjamin Franzke commented on patch set 3 CR -1 04/04/22, 18:35
I think technically this is a breaking change, anyway, at least some more words in the commit message, that .labels have only been provided as bootstrap v4 compat layer would be nice. And if we avoid the Breaking.rst, for that reason, then fine with me, but we should at least "explain" that the bootstrap-v4-legacy-layer is/was not meant to be API in v11.Gruntfile.js:93Can we have one sentence in the commit message that explains this change. What is *your* intention? * Did you face issues/clashes due tue module overwrites ? * Is it only because of personal preference, to be more "explicit". * Or is that maybe new common practice in the sass community? All of that is fine for sure, but let's write that down. Also, do you know any alternatives that allow proper node_modules imports without using relative paths in sass? I'm hoping for something like the following awesome less-css plugin : https://www.npmjs.com/package/less-plugin-npm-import for less? (allows for a npm://$package/ syntax in less imports)._install.scss:105Still .label in here (also in panel-import,panel-info). -
Benjamin Franzke commented on patch set 3 04/04/22, 18:38
Gruntfile.js:93ReplyOr in other words: Should we rather use `includePaths: ['node_modules']` to write @import "bootstrap/scss/functions"; instead of @import "../../node_modules/bootstrap/scss/functions"; -
Benjamin Kott uploaded patch set 4 04/05/22, 07:43
-
Benjamin Kott updated the commit message in patch set 5 04/05/22, 07:45
-
core-ci voted on patch set 5 V +1 04/05/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25474
-
core-ci voted on patch set 4 V +1 04/05/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25472
-
Oliver Klee updated the commit message in patch set 6 04/05/22, 08:39
-
Oliver Klee updated the commit message in patch set 7 04/05/22, 08:39
-
core-ci voted on patch set 6 V +1 04/05/22, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25480
-
core-ci voted on patch set 7 V +1 04/05/22, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25481
-
Benjamin Franzke commented on patch set 7 CR +1 04/05/22, 09:08
Reply
DoneGruntfile.js:93ReplyDone_install.scss:105ReplyDone -
Georg Ringer voted on patch set 7 V +1 CR +1 04/05/22, 10:06
-
Benni Mack voted on patch set 7 V +2 CR +2 04/05/22, 14:08
-
Benni Mack merged patch set 8 04/05/22, 14:08