Review main Merged

74163[TASK] Use bootstrap badges instead of labels

Benjamin Kott CR +2 V +2 Hard +250 −309 updated 04/05/22, 14:08

Commit message

The "label" class was removed in bootstrap 5 and replaced through
"badge". The "label" class was kept in place for a while to keep
the compatibility as high as possible, but it's time to move on.

Since bootstrap 5 also dropped support for severities on certain
components, we are adding them again for the badge to keep the
convenience as high as possible and avoid promoting the "utility css"
approach that was introduced with these decisions as we try to keep
markup changes as low as possible.

This patch also reverts the SCSS includes back to relative paths.

While it is possible to define additional lookup paths for the parser,
so you can have shorter includes - it comes at a cost. The included
sources are opaque to the user and the IDE, this means there is
no support for auto-completion, quick navigation through included files
and can lead to unintended overrides by the user.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 51

Show 31 more files

Review log 1421

  1. Benjamin Kott uploaded patch set 1 04/04/22, 12:25

  2. core-ci voted on patch set 1 V -1 04/04/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25405

  3. Andreas Kienast uploaded patch set 2 04/04/22, 13:47

  4. Andreas Kienast uploaded patch set 3 04/04/22, 13:53

  5. Andreas Kienast voted on patch set 3 V +1 CR +1 04/04/22, 13:53

  6. core-ci voted on patch set 2 V +1 04/04/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25414

  7. core-ci voted on patch set 3 V +1 04/04/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25415

  8. Benjamin Franzke commented on patch set 3 CR -1 04/04/22, 18:35

    I think technically this is a breaking change, anyway, at least some more words in the commit message, that .labels have only been provided as bootstrap v4 compat layer would be nice. And if we avoid the Breaking.rst, for that reason, then fine with me, but we should at least "explain" that the bootstrap-v4-legacy-layer is/was not meant to be API in v11.

    Gruntfile.js:93

    Can we have one sentence in the commit message that explains this change. What is *your* intention? * Did you face issues/clashes due tue module overwrites ? * Is it only because of personal preference, to be more "explicit". * Or is that maybe new common practice in the sass community? All of that is fine for sure, but let's write that down. Also, do you know any alternatives that allow proper node_modules imports without using relative paths in sass? I'm hoping for something like the following awesome less-css plugin : https://www.npmjs.com/package/less-plugin-npm-import for less? (allows for a npm://$package/ syntax in less imports).

    _install.scss:105

    Still .label in here (also in panel-import,panel-info).
  9. Benjamin Franzke commented on patch set 3 04/04/22, 18:38

    Gruntfile.js:93 Reply

    Or in other words: Should we rather use `includePaths: ['node_modules']` to write @import "bootstrap/scss/functions"; instead of @import "../../node_modules/bootstrap/scss/functions";
  10. Benjamin Kott uploaded patch set 4 04/05/22, 07:43

  11. Benjamin Kott updated the commit message in patch set 5 04/05/22, 07:45

  12. core-ci voted on patch set 5 V +1 04/05/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25474

  13. core-ci voted on patch set 4 V +1 04/05/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25472

  14. Oliver Klee updated the commit message in patch set 6 04/05/22, 08:39

  15. Oliver Klee updated the commit message in patch set 7 04/05/22, 08:39

  16. core-ci voted on patch set 6 V +1 04/05/22, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25480

  17. core-ci voted on patch set 7 V +1 04/05/22, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25481

  18. Benjamin Franzke commented on patch set 7 CR +1 04/05/22, 09:08

    Reply

    Done

    Gruntfile.js:93 Reply

    Done

    _install.scss:105 Reply

    Done
  19. Georg Ringer voted on patch set 7 V +1 CR +1 04/05/22, 10:06

  20. Benni Mack voted on patch set 7 V +2 CR +2 04/05/22, 14:08

  21. Benni Mack merged patch set 8 04/05/22, 14:08