74165[!!!][TASK] Migrate backend modal component to lit
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jonas Eberle +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jonas Eberle +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 100
- Build/Sources/Sass/component/_modal.scss+10 −9
- Build/Sources/Sass/typo3/_element_cropper.scss+0 −10
- Build/Sources/TypeScript/backend/element/table-wizard-element.ts+9 −9
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+4 −6
- Build/Sources/TypeScript/backend/form-engine/element/mfa-info-element.ts+3 −3
- Build/Sources/TypeScript/backend/layout-module/paste.ts+4 −13
- Build/Sources/TypeScript/backend/page-tree/page-tree-element.ts+14 −14
- Build/Sources/TypeScript/backend/toolbar/shortcut-menu.ts+19 −20
- Build/Sources/TypeScript/backend/tree/file-storage-tree-container.ts+12 −11
- Build/Sources/TypeScript/backend/ajax-data-handler.ts+6 −6
- Build/Sources/TypeScript/backend/column-selector-button.ts+5 −5
- Build/Sources/TypeScript/backend/context-menu-actions.ts+11 −12
- Build/Sources/TypeScript/backend/drag-uploader.ts+40 −29
- Build/Sources/TypeScript/backend/form-engine-validation.ts+3 −4
- Build/Sources/TypeScript/backend/form-engine.ts+35 −35
- Build/Sources/TypeScript/backend/grid-editor.ts+14 −13
- Build/Sources/TypeScript/backend/image-manipulation.ts+70 −76
- Build/Sources/TypeScript/backend/modal.ts6+303 −283
Show 80 more files
- Build/Sources/TypeScript/backend/multi-step-wizard.ts+15 −13
- Build/Sources/TypeScript/backend/new-content-element-wizard-button.ts+2 −2
- Build/Sources/TypeScript/backend/new-content-element-wizard.ts+1 −1
- Build/Sources/TypeScript/backend/online-media.ts+9 −8
- Build/Sources/TypeScript/backend/wizard.ts2+15 −13
- Build/Sources/TypeScript/core/authentication/mfa-provider/totp.ts+6 −12
- Build/Sources/TypeScript/core/lit-helper.ts+14 −1
- Build/Sources/TypeScript/dashboard/dashboard-delete.ts+4 −3
- Build/Sources/TypeScript/dashboard/dashboard-modal.ts+9 −10
- Build/Sources/TypeScript/dashboard/widget-remover.ts+5 −4
- Build/Sources/TypeScript/dashboard/widget-selector.ts+3 −5
- Build/Sources/TypeScript/extensionmanager/main.ts+5 −7
- Build/Sources/TypeScript/extensionmanager/repository.ts+9 −5
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+6 −6
- Build/Sources/TypeScript/filelist/create-folder.ts+4 −4
- Build/Sources/TypeScript/filelist/file-delete.ts+6 −6
- Build/Sources/TypeScript/filelist/file-list.ts+4 −4
- Build/Sources/TypeScript/filelist/rename-file.ts+7 −5
- Build/Sources/TypeScript/impexp/import-export.ts+10 −10
- Build/Sources/TypeScript/install/module/upgrade/extension-compat-tester.ts+4 −3
- Build/Sources/TypeScript/install/module/upgrade/extension-scanner.ts+1 −1
- Build/Sources/TypeScript/install/router.ts+16 −9
- Build/Sources/TypeScript/recordlist/record-download-button.ts+6 −6
- Build/Sources/TypeScript/recordlist/recordlist.ts+4 −4
- Build/Sources/TypeScript/rte_ckeditor/rte-link-browser.ts+1 −1
- Build/Sources/TypeScript/workspaces/backend.ts+25 −26
- Build/Sources/TypeScript/workspaces/preview.ts+10 −9
- Build/Sources/TypeScript/workspaces/workspaces.ts+5 −5
- typo3/sysext/backend/Resources/Private/Templates/Form/ImageManipulationWizard.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/table-wizard-element.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/mfa-info-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/paste.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/shortcut-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/column-selector-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/image-manipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+44 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-step-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/online-media.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98288-UpdatedBackendModalAPI.rstnew+137 −0
- typo3/sysext/core/Resources/Public/JavaScript/authentication/mfa-provider/totp.js+4 −4
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard-delete.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard-modal.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-remover.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-selector.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/create-folder.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-delete.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/rename-file.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/modals-component.js8+12 −12
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+7 −7
- typo3/sysext/impexp/Resources/Public/JavaScript/import-export.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-compat-tester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-scanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/record-download-button.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/typo3link.js+5 −4
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/rte-link-browser.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/workspaces.js+1 −1
Review log 4164
Show 2039 earlier messages
-
Benjamin Franzke uploaded patch set 1 04/04/22, 12:37
-
Benjamin Franzke wrote 04/04/22, 12:42
Topic set to lit -
core-ci voted on patch set 1 V -1 04/04/22, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25407
-
Benjamin Franzke uploaded patch set 2 04/04/22, 20:31
-
core-ci voted on patch set 2 V -1 04/04/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25457
-
Benjamin Franzke uploaded patch set 3 04/05/22, 04:37
-
core-ci voted on patch set 3 V -1 04/05/22, 04:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25464
-
Benjamin Franzke uploaded patch set 4 04/05/22, 06:10
-
core-ci voted on patch set 4 V +1 04/05/22, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25465
-
Benjamin Franzke uploaded patch set 5 04/05/22, 06:49
-
core-ci voted on patch set 5 V -1 04/05/22, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25468
-
core-ci voted on patch set 5 V +1 04/05/22, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25468
-
Benjamin Franzke uploaded patch set 6 04/05/22, 09:28
-
core-ci voted on patch set 6 V -1 04/05/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25483
-
core-ci voted on patch set 6 V +1 04/05/22, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25483
-
Benjamin Franzke uploaded patch set 7 04/05/22, 12:17
-
core-ci voted on patch set 7 V +1 04/05/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25504
-
Benjamin Franzke uploaded patch set 8 04/05/22, 14:10
-
Benjamin Franzke uploaded patch set 9 04/05/22, 14:11
-
core-ci voted on patch set 9 V +1 04/05/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25512
-
Benjamin Franzke uploaded patch set 10 04/05/22, 14:35
-
Benjamin Franzke uploaded patch set 11 04/05/22, 14:46
-
core-ci voted on patch set 10 V +1 04/05/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25515
-
core-ci voted on patch set 11 V +1 04/05/22, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25518
-
Benjamin Franzke uploaded patch set 12 04/05/22, 18:50
-
core-ci voted on patch set 12 V +1 04/05/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25552
-
Benjamin Franzke uploaded patch set 13 04/16/22, 02:36
-
core-ci voted on patch set 13 V -1 04/16/22, 02:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26084
-
core-ci voted on patch set 13 V +1 04/16/22, 03:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26084
-
Benjamin Franzke uploaded patch set 14 05/05/22, 18:00
-
core-ci voted on patch set 14 V -1 05/05/22, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26885
-
Benjamin Franzke uploaded patch set 15 09/07/22, 18:15
-
core-ci voted on patch set 15 V +1 09/07/22, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30777
-
Benjamin Franzke uploaded patch set 16 09/07/22, 19:47
-
Benjamin Franzke uploaded patch set 17 09/07/22, 21:12
-
core-ci voted on patch set 17 V +1 09/07/22, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30786
-
Benjamin Franzke uploaded patch set 18 09/07/22, 21:55
-
core-ci voted on patch set 18 V +1 09/07/22, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30787
-
Benni Mack voted on patch set 18 CR +1 09/08/22, 08:10
-
Jonas Eberle commented on patch set 18 09/08/22, 09:09
Thanks!modal.ts:287Could be target?.dataset?.eventNamemodals-component.js:204hideModal()modals-component.js:215hideModal()modals-component.js:512hideModal() -
Andreas Kienast commented on patch set 18 09/08/22, 09:26
modals-component.js:204ReplyWhat do you mean? Do you want to rename the method in modal.ts? -
Andreas Kienast commented on patch set 18 CR -1 09/08/22, 09:27
modals-component.js:204ReplyAh, that's JavaScript, not TypeScript. Looks valid, thanks! -
Andreas Kienast commented on patch set 18 09/08/22, 09:29
on it -
Benjamin Franzke uploaded patch set 19 09/08/22, 09:35
-
Benjamin Franzke commented on patch set 19 09/08/22, 09:35
modal.ts:287ReplyAck, would be better. But I see that the method actually became unused right now. Dropped.modals-component.js:204Replyoops, ugly late adaptions. :\ Fixed.modals-component.js:215ReplyDonemodals-component.js:512ReplyDone -
core-ci voted on patch set 19 V +1 09/08/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30800
-
Benjamin Franzke uploaded patch set 20 09/08/22, 11:21
-
Benjamin Franzke commented on patch set 20 09/08/22, 11:21
modal.ts:18ReplyThanks, done. I've also checked the other files with vscode (i have no import-checker in my regular text editor unfortunately) and fixed other cases as well.modal.ts:29ReplyDone -
core-ci voted on patch set 20 V +1 09/08/22, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30806
-
Benni Mack voted on patch set 20 V +1 CR +1 09/08/22, 11:48
-
Oli Bartsch commented on patch set 20 V -1 09/08/22, 12:04
Using the "OK" button in the workspaces modal to send multiple records to the next stage triggers a JavaScript error: utility.js?bust=1662638576:13 Uncaught TypeError: Cannot read properties of null (reading 'querySelectorAll') at Utility.convertFormToObject (utility.js?bust=1662638576:13:845) at ModalElement.<anonymous> (backend.js?bust=1662638576:13:7636) at ModalElement._buttonClick (modal.js?bust=1662638576:43:170) at ModalElement.<anonymous> (modal.js?bust=1662638576:52:32) at I.handleEvent (lit-html.js:6:7272) -
Oli Bartsch commented on patch set 20 V 0 09/08/22, 12:05
wizard.ts:170Seems like a leftover. -
Oli Bartsch voted on patch set 20 V -1 09/08/22, 12:05
-
Oli Bartsch commented on patch set 20 09/08/22, 12:06
Reply
.. unresolve comment -
Benjamin Franzke uploaded patch set 21 09/08/22, 12:37
-
core-ci voted on patch set 21 V +1 09/08/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30814
-
Andreas Kienast uploaded patch set 22 09/08/22, 14:53
-
core-ci voted on patch set 22 V +1 09/08/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30830
-
Andreas Kienast voted on patch set 22 V +1 CR +1 09/08/22, 15:05
-
Jonas Eberle voted on patch set 22 V +1 CR +1 09/08/22, 15:19
-
Benjamin Franzke voted on patch set 22 V +2 CR +2 09/08/22, 15:28
-
Benjamin Franzke merged patch set 23 09/08/22, 15:28