Review main Merged Breaking

74165[!!!][TASK] Migrate backend modal component to lit

Benjamin Franzke CR +2 V +2 Expert +1030 −822 updated 09/08/22, 15:28

Commit message

Avoid jQuery and especially the bootstrap
jQuery compat layer.
Use lit as template engine instead of jQuery composition
and avoid the bootstrap jQuery compat layer for initialization.

Will allow lit's TemplateResult to be directly passed
to the modal as content, allowing for a secure and
straight forward templating system for the modal API.

Left for another patch is the migration of
AbstractInteractableModule away from jQuery
and the adaption of login-refresh.ts to use
the TYPO3 Modal api, instead of directly calling
into bootstraps jQuery-Modal API.

Support for jQuery based modal content is kept for
now, as it doesn't require us to load jQuery
proactively and may ease migration for some users,
but lit TemplateResults are suggested to be used
instead. The jQuery content support may be
deprecated in an upcoming sprint release.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jonas Eberle +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 100

Show 80 more files

Review log 4164

Show 2039 earlier messages
  1. Benjamin Franzke uploaded patch set 1 04/04/22, 12:37

  2. Benjamin Franzke wrote 04/04/22, 12:42

    Topic set to lit
  3. core-ci voted on patch set 1 V -1 04/04/22, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25407

  4. Benjamin Franzke uploaded patch set 2 04/04/22, 20:31

  5. core-ci voted on patch set 2 V -1 04/04/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25457

  6. Benjamin Franzke uploaded patch set 3 04/05/22, 04:37

  7. core-ci voted on patch set 3 V -1 04/05/22, 04:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25464

  8. Benjamin Franzke uploaded patch set 4 04/05/22, 06:10

  9. core-ci voted on patch set 4 V +1 04/05/22, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25465

  10. Benjamin Franzke uploaded patch set 5 04/05/22, 06:49

  11. core-ci voted on patch set 5 V -1 04/05/22, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25468

  12. core-ci voted on patch set 5 V +1 04/05/22, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25468

  13. Benjamin Franzke uploaded patch set 6 04/05/22, 09:28

  14. core-ci voted on patch set 6 V -1 04/05/22, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25483

  15. core-ci voted on patch set 6 V +1 04/05/22, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25483

  16. Benjamin Franzke uploaded patch set 7 04/05/22, 12:17

  17. core-ci voted on patch set 7 V +1 04/05/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25504

  18. Benjamin Franzke uploaded patch set 8 04/05/22, 14:10

  19. Benjamin Franzke uploaded patch set 9 04/05/22, 14:11

  20. core-ci voted on patch set 9 V +1 04/05/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25512

  21. Benjamin Franzke uploaded patch set 10 04/05/22, 14:35

  22. Benjamin Franzke uploaded patch set 11 04/05/22, 14:46

  23. core-ci voted on patch set 10 V +1 04/05/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25515

  24. core-ci voted on patch set 11 V +1 04/05/22, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25518

  25. Benjamin Franzke uploaded patch set 12 04/05/22, 18:50

  26. core-ci voted on patch set 12 V +1 04/05/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25552

  27. Benjamin Franzke uploaded patch set 13 04/16/22, 02:36

  28. core-ci voted on patch set 13 V -1 04/16/22, 02:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26084

  29. core-ci voted on patch set 13 V +1 04/16/22, 03:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26084

  30. Benjamin Franzke uploaded patch set 14 05/05/22, 18:00

  31. core-ci voted on patch set 14 V -1 05/05/22, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26885

  32. Benjamin Franzke uploaded patch set 15 09/07/22, 18:15

  33. core-ci voted on patch set 15 V +1 09/07/22, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30777

  34. Benjamin Franzke uploaded patch set 16 09/07/22, 19:47

  35. Benjamin Franzke uploaded patch set 17 09/07/22, 21:12

  36. core-ci voted on patch set 17 V +1 09/07/22, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30786

  37. Benjamin Franzke uploaded patch set 18 09/07/22, 21:55

  38. core-ci voted on patch set 18 V +1 09/07/22, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30787

  39. Benni Mack voted on patch set 18 CR +1 09/08/22, 08:10

  1. Jonas Eberle commented on patch set 18 09/08/22, 09:09

    Thanks!

    modal.ts:287

    Could be target?.dataset?.eventName

    modals-component.js:204

    hideModal()

    modals-component.js:215

    hideModal()

    modals-component.js:512

    hideModal()
  2. Andreas Kienast commented on patch set 18 09/08/22, 09:26

    modals-component.js:204 Reply

    What do you mean? Do you want to rename the method in modal.ts?
  3. Andreas Kienast commented on patch set 18 CR -1 09/08/22, 09:27

    modals-component.js:204 Reply

    Ah, that's JavaScript, not TypeScript. Looks valid, thanks!
  4. Andreas Kienast commented on patch set 18 09/08/22, 09:29

    on it
  5. Benjamin Franzke uploaded patch set 19 09/08/22, 09:35

  6. Benjamin Franzke commented on patch set 19 09/08/22, 09:35

    modal.ts:287 Reply

    Ack, would be better. But I see that the method actually became unused right now. Dropped.

    modals-component.js:204 Reply

    oops, ugly late adaptions. :\ Fixed.

    modals-component.js:215 Reply

    Done

    modals-component.js:512 Reply

    Done
  7. Andreas Kienast commented on patch set 19 09/08/22, 09:37

    modal.ts:18

    unused

    modal.ts:29

    unused
  8. core-ci voted on patch set 19 V +1 09/08/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30800

  9. Benjamin Franzke uploaded patch set 20 09/08/22, 11:21

  10. Benjamin Franzke commented on patch set 20 09/08/22, 11:21

    modal.ts:18 Reply

    Thanks, done. I've also checked the other files with vscode (i have no import-checker in my regular text editor unfortunately) and fixed other cases as well.

    modal.ts:29 Reply

    Done
  11. core-ci voted on patch set 20 V +1 09/08/22, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30806

  12. Benni Mack voted on patch set 20 V +1 CR +1 09/08/22, 11:48

  13. Oli Bartsch commented on patch set 20 V -1 09/08/22, 12:04

    Using the "OK" button in the workspaces modal to send multiple records to the next stage triggers a JavaScript error: utility.js?bust=1662638576:13 Uncaught TypeError: Cannot read properties of null (reading 'querySelectorAll') at Utility.convertFormToObject (utility.js?bust=1662638576:13:845) at ModalElement.<anonymous> (backend.js?bust=1662638576:13:7636) at ModalElement._buttonClick (modal.js?bust=1662638576:43:170) at ModalElement.<anonymous> (modal.js?bust=1662638576:52:32) at I.handleEvent (lit-html.js:6:7272)
  14. Oli Bartsch commented on patch set 20 V 0 09/08/22, 12:05

    wizard.ts:170

    Seems like a leftover.
  15. Oli Bartsch voted on patch set 20 V -1 09/08/22, 12:05

  16. Oli Bartsch commented on patch set 20 09/08/22, 12:06

    Reply

    .. unresolve comment
  17. Benjamin Franzke uploaded patch set 21 09/08/22, 12:37

  18. Benjamin Franzke commented on patch set 21 09/08/22, 12:37

    Reply

    Ack

    wizard.ts:170 Reply

    Ack. (-‸ლ)
  19. core-ci voted on patch set 21 V +1 09/08/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30814

  20. Andreas Kienast uploaded patch set 22 09/08/22, 14:53

  21. core-ci voted on patch set 22 V +1 09/08/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30830

  22. Andreas Kienast voted on patch set 22 V +1 CR +1 09/08/22, 15:05

  23. Jonas Eberle voted on patch set 22 V +1 CR +1 09/08/22, 15:19

  24. Benjamin Franzke voted on patch set 22 V +2 CR +2 09/08/22, 15:28

  25. Benjamin Franzke merged patch set 23 09/08/22, 15:28