74166[TASK] Replace chosen with Choices.js
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 21
- Build/patches/choices.js+10.1.0.patchnew+22 −0
- Build/Sources/Sass/libs/_choices.scssnew+404 −0
- Build/Sources/Sass/libs/_chosen.scssdeleted+0 −457
- Build/Sources/Sass/backend.scss+1 −1
- Build/Sources/TypeScript/install/module/settings/system-maintainer.ts+17 −28
- Build/Sources/TypeScript/install/module/upgrade/upgrade-docs.ts1+38 −80
- Build/types/TYPO3/index.d.ts+1 −1
- Build/Gruntfile.js+5 −4
- Build/package-lock.json+51 −28
- Build/package.json+1 −2
- Build/tsconfig.json+0 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/SettingsCest.php+5 −5
- typo3/sysext/form/Resources/Public/Css/form.css+2 −2
- typo3/sysext/install/Resources/Private/Templates/Settings/SystemMaintainer.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeDocsGetContent.html+2 −5
- typo3/sysext/install/Resources/Public/JavaScript/element/taggable-element.js1new+13 −0
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/system-maintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-docs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/choices.jsnew+2 −0
Review log 1425
-
Andreas Kienast uploaded patch set 1 04/04/22, 13:28
-
core-ci voted on patch set 1 V -1 04/04/22, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25413
-
Benjamin Franzke uploaded patch set 2 04/04/22, 14:01
-
Benjamin Franzke uploaded patch set 3 04/04/22, 14:11
-
core-ci voted on patch set 2 V -1 04/04/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25418
-
core-ci voted on patch set 3 V -1 04/04/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25419
-
Andreas Kienast uploaded patch set 4 09/20/22, 16:04
-
core-ci voted on patch set 4 V -1 09/20/22, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31326
-
Andreas Kienast uploaded patch set 5 09/21/22, 10:12
-
core-ci voted on patch set 5 V -1 09/21/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31344
-
Andreas Kienast uploaded patch set 6 09/21/22, 10:23
-
Andreas Kienast uploaded patch set 7 09/21/22, 10:31
-
core-ci voted on patch set 6 V -1 09/21/22, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31345
-
core-ci voted on patch set 7 V -1 09/21/22, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31347
-
Andreas Kienast uploaded patch set 8 09/21/22, 11:19
-
core-ci voted on patch set 8 V -1 09/21/22, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31351
-
Andreas Kienast uploaded patch set 9 09/21/22, 11:43
-
core-ci voted on patch set 9 V +1 09/21/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31352
-
Andreas Kienast uploaded patch set 10 09/21/22, 13:07
-
core-ci voted on patch set 10 V +1 09/21/22, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31370
-
Andreas Kienast uploaded patch set 11 09/21/22, 15:05
-
core-ci voted on patch set 11 V -1 09/21/22, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31383
-
Christian Kuhn commented on patch set 11 V -1 09/21/22, 15:21
details - communicated with andy already. -
Andreas Kienast commented on patch set 11 CR -2 09/22/22, 06:29
upgrade-docs.ts:161UnresolvedI just found out this is slower by a factor of 3 compared to the previous solution.taggable-element.js:1UnresolvedObsolete file I had in build cache -
Andreas Kienast abandoned the change 11/11/22, 15:00