Review main Abandoned

74166[TASK] Replace chosen with Choices.js

Andreas Kienast CR 0 V 0 Expert +570 −621 updated 11/11/22, 15:00

Commit message

This patch replaces the outdated `chosen-js` library with `Choices.js`,
with has been revived and also feels snappier than `chosen-js`.

Due to an outstanding bug [1], an npm patch is provided until the issue
is solved.

[1] https://github.com/Choices-js/Choices/issues/1057

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 21

Review log 1425

  1. Andreas Kienast uploaded patch set 1 04/04/22, 13:28

  2. core-ci voted on patch set 1 V -1 04/04/22, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25413

  3. Benjamin Franzke uploaded patch set 2 04/04/22, 14:01

  4. Benjamin Franzke uploaded patch set 3 04/04/22, 14:11

  5. core-ci voted on patch set 2 V -1 04/04/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25418

  6. core-ci voted on patch set 3 V -1 04/04/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25419

  7. Andreas Kienast uploaded patch set 4 09/20/22, 16:04

  8. core-ci voted on patch set 4 V -1 09/20/22, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31326

  9. Andreas Kienast uploaded patch set 5 09/21/22, 10:12

  10. core-ci voted on patch set 5 V -1 09/21/22, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31344

  11. Andreas Kienast uploaded patch set 6 09/21/22, 10:23

  12. Andreas Kienast uploaded patch set 7 09/21/22, 10:31

  13. core-ci voted on patch set 6 V -1 09/21/22, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31345

  14. core-ci voted on patch set 7 V -1 09/21/22, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31347

  15. Andreas Kienast uploaded patch set 8 09/21/22, 11:19

  16. core-ci voted on patch set 8 V -1 09/21/22, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31351

  17. Andreas Kienast uploaded patch set 9 09/21/22, 11:43

  18. core-ci voted on patch set 9 V +1 09/21/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31352

  19. Andreas Kienast uploaded patch set 10 09/21/22, 13:07

  20. core-ci voted on patch set 10 V +1 09/21/22, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31370

  21. Andreas Kienast uploaded patch set 11 09/21/22, 15:05

  22. core-ci voted on patch set 11 V -1 09/21/22, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31383

  23. Christian Kuhn commented on patch set 11 V -1 09/21/22, 15:21

    details - communicated with andy already.
  24. Andreas Kienast commented on patch set 11 CR -2 09/22/22, 06:29

    upgrade-docs.ts:161 Unresolved

    I just found out this is slower by a factor of 3 compared to the previous solution.

    taggable-element.js:1 Unresolved

    Obsolete file I had in build cache
  25. Andreas Kienast abandoned the change 11/11/22, 15:00