Review main Merged

74168[TASK] Remove unused variable in AbstractItemProvider

Nikita Hovratov CR +2 V +2 Easy +0 −2 updated 04/04/22, 17:24

Commit message

After the removal of the fourth parameter of the
checkAuthMode method, the local variable $authMode
has not been removed, too.

In addition, the @todo is removed, as it is resolved
now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 04/04/22, 16:15

  2. core-ci voted on patch set 1 V +1 04/04/22, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25440

  3. Stefan Bürk commented on patch set 1 04/04/22, 16:29

    wonder why phpstan has not detected this as unused var ..
  4. Nikita Hovratov commented on patch set 1 04/04/22, 16:38

    Reply

    does phpstan usually find those?
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 04/04/22, 17:24

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/04/22, 17:24

  7. Christian Kuhn merged patch set 2 04/04/22, 17:24