Review main Merged

74178[BUGFIX] Avoid global jQuery usage in RTE link wizard

Benjamin Franzke CR +2 V +2 Easy +8 −1 updated 04/05/22, 12:49

Commit message

The global variable $ (window.$) has been removed with #97243.
This caused the RTE link wizard to fail with a JavaScript
error as $.isEmptyObject is used in typo3link.js.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 04/05/22, 11:53

  2. Benjamin Franzke uploaded patch set 2 04/05/22, 11:55

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 04/05/22, 12:15

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 04/05/22, 12:21

  5. core-ci voted on patch set 1 V +1 04/05/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25496

  6. core-ci voted on patch set 2 V +1 04/05/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25500

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 04/05/22, 12:49

  8. Andreas Kienast merged patch set 3 04/05/22, 12:49