Review main Merged

74180[TASK] Use ckeditor's native readOnly mode

Andreas Kienast CR +2 V +2 Easy +6 −4 updated 04/05/22, 15:11

Commit message

Textarea can be configured in TCA to be read only and to have a richtext
editor enabled. If `readOnly` is enabled, ckeditor is now rendered in a
read-only mode instead of rendering a plain textarea containing HTML
markup.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Andreas Kienast uploaded patch set 1 04/05/22, 12:47

  2. core-ci voted on patch set 1 V -1 04/05/22, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25506

  3. core-ci voted on patch set 1 V +1 04/05/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25506

  4. Benjamin Franzke commented on patch set 1 CR +1 04/05/22, 13:29

    RichTextNodeResolver.php:56

    comment should be dropped
  5. Andreas Kienast commented on patch set 1 04/05/22, 13:30

    RichTextNodeResolver.php:56 Reply

    Ack
  6. Andreas Kienast uploaded patch set 2 04/05/22, 13:31

  7. core-ci voted on patch set 2 V +1 04/05/22, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25508

  8. Susi Moog voted on patch set 2 V +1 CR +1 04/05/22, 14:27

  9. Oli Bartsch commented on patch set 2 V +1 CR +1 04/05/22, 14:31

    Can be tested with styleguide "tx_styleguide_l10nreadonly".
  10. Oli Bartsch voted on patch set 2 CR 0 04/05/22, 14:38

  11. Oli Bartsch uploaded patch set 3 04/05/22, 14:49

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 04/05/22, 14:49

  13. Susi Moog voted on patch set 3 V +1 CR +1 04/05/22, 14:50

  14. core-ci voted on patch set 3 V -1 04/05/22, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25520

  15. core-ci voted on patch set 3 V +1 04/05/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25520

  16. Andreas Kienast voted on patch set 3 V +2 CR +2 04/05/22, 15:10

  17. Andreas Kienast merged patch set 4 04/05/22, 15:11