Review main Merged

74181[BUGFIX] Keep schema in http_makelinks

Achim Fritz CR +2 V +2 Normal +158 −1 updated 04/22/22, 21:30

Commit message

Add schema again to typolink configuration parameter
before create typolink

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Achim Fritz uploaded patch set 1 04/05/22, 13:35

  2. core-ci voted on patch set 1 V +1 04/05/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25509

  3. Simon Schaufelberger commented on patch set 1 CR -1 04/07/22, 23:47

    This should be covered by a test
  4. Simon Schaufelberger uploaded patch set 2 04/21/22, 14:52

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/21/22, 14:52

  6. core-ci voted on patch set 2 V +1 04/21/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26275

  7. Simon Schaufelberger updated the commit message in patch set 3 04/21/22, 15:25

  8. Simon Schaufelberger voted on patch set 3 V +1 CR +1 04/21/22, 15:29

  9. core-ci voted on patch set 3 V +1 04/21/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26276

  10. Simon Schaufelberger uploaded patch set 4 04/22/22, 11:02

  11. Simon Schaufelberger uploaded patch set 5 04/22/22, 11:05

  12. core-ci voted on patch set 5 V +1 04/22/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26297

  13. core-ci voted on patch set 4 V +1 04/22/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26296

  14. Benni Mack voted on patch set 5 V +1 CR +1 04/22/22, 14:44

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 04/22/22, 15:24

  16. Stefan Bürk voted on patch set 5 V +2 CR +2 04/22/22, 19:42

  17. Stefan Bürk merged patch set 6 04/22/22, 19:42

  18. Simon Schaufelberger commented on patch set 6 04/22/22, 20:59

    Release 10.4 is wrong. No backport needed. sorry
  19. Stefan Bürk commented on patch set 6 04/22/22, 21:02

    Backport to v10 needs quite some additional changes which may introduce sideeffects. Thus not doing v10 backport for now.
  20. Simon Schaufelberger commented on patch set 6 04/22/22, 21:30

    Fun fact: It actually worked in v10 and got broken with v11.