74182[TASK] Refresh the look of pagemodule
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- André Kraus +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 19
- Build/Sources/Sass/module/_page.scss3+233 −273
- Build/Sources/Sass/typo3/_element_buttons.scss+6 −0
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+1 −1
- Build/Sources/TypeScript/backend/layout-module/paste.ts+1 −1
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php2+40 −50
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+28 −9
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+11 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php+24 −25
- typo3/sysext/backend/Classes/View/PageLayoutViewDrawEmptyColposContent.php+4 −8
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html1+12 −16
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+10 −12
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/paste.js+1 −1
- typo3/sysext/frontend/Classes/Preview/ImagePreviewRenderer.php+0 −14
- typo3/sysext/frontend/Classes/Preview/TextmediaPreviewRenderer.php+2 −16
- typo3/sysext/frontend/Classes/Preview/TextpicPreviewRenderer.php+2 −16
- typo3/sysext/frontend/Classes/Preview/TextPreviewRenderer.php+1 −1
Review log 1925
-
Benjamin Kott uploaded patch set 1 04/05/22, 15:33
-
core-ci voted on patch set 1 V -1 04/05/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25528
-
Benjamin Kott uploaded patch set 2 04/05/22, 15:46
-
Benjamin Kott uploaded patch set 3 04/05/22, 15:48
-
core-ci voted on patch set 3 V -1 04/05/22, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25536
-
core-ci voted on patch set 2 V -1 04/05/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25535
-
Benjamin Kott uploaded patch set 4 04/05/22, 16:19
-
Benjamin Kott uploaded patch set 5 04/05/22, 16:22
-
core-ci voted on patch set 4 V -1 04/05/22, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25539
-
core-ci voted on patch set 5 V +1 04/05/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25540
-
Andreas Kienast voted on patch set 5 V +1 CR +1 04/05/22, 16:37
-
André Kraus voted on patch set 5 V +1 04/05/22, 16:38
-
Frank Nägler commented on patch set 5 V +1 04/05/22, 16:39
wrong comment, else it looks very goodStandardContentPreviewRenderer.php:397$str = $linkTest -
Andreas Kienast commented on patch set 6 04/05/22, 16:45
Published edit on patch set 5. -
Andreas Kienast voted on patch set 6 V +1 CR +1 04/05/22, 16:45
-
Frank Nägler voted on patch set 6 V +1 CR +1 04/05/22, 16:46
-
Frank Nägler commented on patch set 6 04/05/22, 16:47
StandardContentPreviewRenderer.php:397ReplyDone -
André Kraus voted on patch set 6 V +1 04/05/22, 16:48
-
core-ci voted on patch set 6 V +1 04/05/22, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25544
-
Oli Bartsch commented on patch set 6 04/05/22, 17:02
Header.html:21This should be a <button> as it has no target. -
Andreas Kienast voted on patch set 6 V +2 CR +2 04/05/22, 17:03
-
Andreas Kienast merged patch set 7 04/05/22, 17:03
-
Benjamin Franzke commented on patch set 7 04/05/22, 18:41
_page.scss:19UnresolvedInconsistent border-radius between cells and elements result in an inconsistent look and feel (IMO)._page.scss:128UnresolvedWhy is box-shadow applied to content elements but not to grid cells? That results in inconsistent elevation. The gray-cell background, therefore looks awkward compared to the content elements. Somehow elevated, somehow not. Is this inconsitent by accident or by intent?_page.scss:189UnresolvedOk, so we now have: * left-aligned content elements icons * right-aligned content elements actions * (and new!) centered grid actions That means previously the editor had two angles to decide between, now there are three different position where the mouse has to move to. -
Annett Jähnichen commented on patch set 7 04/06/22, 14:57
Here you can find a valid description why we as UX Initiative propose to move the delete button to the context menu. https://forge.typo3.org/issues/95247#note-4 and also the other forge ticket related to that changes https://forge.typo3.org/issues/94629 -
Christian Kuhn commented on patch set 7 04/06/22, 16:20
for the record: post -1 from me for this patch, in short: incomplete commit message, merged far too quickly, questionable ux decisions. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/74200 for revert proposal.