Review main Merged

74182[TASK] Refresh the look of pagemodule

Benjamin Kott CR +2 V +2 Hard +380 −447 updated 04/06/22, 16:20

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • André Kraus +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1925

  1. Benjamin Kott uploaded patch set 1 04/05/22, 15:33

  2. core-ci voted on patch set 1 V -1 04/05/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25528

  3. Benjamin Kott uploaded patch set 2 04/05/22, 15:46

  4. Benjamin Kott uploaded patch set 3 04/05/22, 15:48

  5. core-ci voted on patch set 3 V -1 04/05/22, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25536

  6. core-ci voted on patch set 2 V -1 04/05/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25535

  7. Benjamin Kott uploaded patch set 4 04/05/22, 16:19

  8. Benjamin Kott uploaded patch set 5 04/05/22, 16:22

  9. core-ci voted on patch set 4 V -1 04/05/22, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25539

  10. core-ci voted on patch set 5 V +1 04/05/22, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25540

  11. Andreas Kienast voted on patch set 5 V +1 CR +1 04/05/22, 16:37

  12. André Kraus voted on patch set 5 V +1 04/05/22, 16:38

  13. Frank Nägler commented on patch set 5 V +1 04/05/22, 16:39

    wrong comment, else it looks very good

    StandardContentPreviewRenderer.php:397

    $str = $linkTest
  14. Andreas Kienast commented on patch set 6 04/05/22, 16:45

    Published edit on patch set 5.
  15. Andreas Kienast voted on patch set 6 V +1 CR +1 04/05/22, 16:45

  16. Frank Nägler voted on patch set 6 V +1 CR +1 04/05/22, 16:46

  17. Frank Nägler commented on patch set 6 04/05/22, 16:47

    StandardContentPreviewRenderer.php:397 Reply

    Done
  18. André Kraus voted on patch set 6 V +1 04/05/22, 16:48

  19. core-ci voted on patch set 6 V +1 04/05/22, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25544

  20. Oli Bartsch commented on patch set 6 04/05/22, 17:02

    Header.html:21

    This should be a <button> as it has no target.
  21. Andreas Kienast voted on patch set 6 V +2 CR +2 04/05/22, 17:03

  22. Andreas Kienast merged patch set 7 04/05/22, 17:03

  23. Benjamin Franzke commented on patch set 7 04/05/22, 18:41

    _page.scss:19 Unresolved

    Inconsistent border-radius between cells and elements result in an inconsistent look and feel (IMO).

    _page.scss:128 Unresolved

    Why is box-shadow applied to content elements but not to grid cells? That results in inconsistent elevation. The gray-cell background, therefore looks awkward compared to the content elements. Somehow elevated, somehow not. Is this inconsitent by accident or by intent?

    _page.scss:189 Unresolved

    Ok, so we now have: * left-aligned content elements icons * right-aligned content elements actions * (and new!) centered grid actions That means previously the editor had two angles to decide between, now there are three different position where the mouse has to move to.
  24. Annett Jähnichen commented on patch set 7 04/06/22, 14:57

    Here you can find a valid description why we as UX Initiative propose to move the delete button to the context menu. https://forge.typo3.org/issues/95247#note-4 and also the other forge ticket related to that changes https://forge.typo3.org/issues/94629
  25. Christian Kuhn commented on patch set 7 04/06/22, 16:20

    for the record: post -1 from me for this patch, in short: incomplete commit message, merged far too quickly, questionable ux decisions. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/74200 for revert proposal.