Review main Merged

74185[BUGFIX] Apply workspace context in FileRepository::findByRelation

Oliver Hader CR +2 V +2 Easy +6 −1 updated 05/03/22, 11:41

Commit message

FileRepository::findByRelation does not apply any workspace context
when invoked in backend context.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • André Kraus +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • André Kraus +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Oliver Hader uploaded patch set 1 04/05/22, 16:35

  2. core-ci voted on patch set 1 V +1 04/05/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25541

  3. Benni Mack voted on patch set 1 CR +1 04/05/22, 16:53

  4. Andreas Kienast voted on patch set 1 CR +1 04/05/22, 17:04

  5. André Kraus voted on patch set 1 V -1 04/06/22, 07:23

  6. André Kraus commented on patch set 2 04/06/22, 09:18

    Published edit on patch set 1.
  7. André Kraus voted on patch set 2 V +1 CR +1 04/06/22, 09:19

  8. core-ci voted on patch set 2 V -1 04/06/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25600

  9. core-ci voted on patch set 2 V +1 04/06/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25600

  10. Andreas Kienast voted on patch set 2 CR +1 04/07/22, 13:25

  11. Oliver Hader commented on patch set 2 04/07/22, 13:29

    Addition looks good, feels like there should be additional tests
  12. Andreas Kienast commented on patch set 2 V +1 CR 0 04/07/22, 13:38

    The patch works with a modified contentblocks_req_api, but I agree this deserves some tests.
  13. Benni Mack voted on patch set 2 CR +1 05/02/22, 20:52

  14. Oliver Hader voted on patch set 2 V +2 CR +2 05/03/22, 11:38

  15. Oliver Hader merged patch set 3 05/03/22, 11:41